Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile time warnings #352

Merged
merged 4 commits into from
Oct 7, 2020
Merged

fix compile time warnings #352

merged 4 commits into from
Oct 7, 2020

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Oct 5, 2020

As indicated in subject, quick fix to eliminate compile time warnings originating from -Wsign-compare and -Wreorder flags.

@lalitb lalitb requested a review from a team October 5, 2020 14:50
@codecov
Copy link

codecov bot commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         154      154           
  Lines        6853     6853           
=======================================
  Hits         6491     6491           
  Misses        362      362
Impacted Files Coverage Δ
api/include/opentelemetry/context/context.h 100.00% <ø> (ø)
...opentelemetry/exporters/ostream/metrics_exporter.h 98.66% <100.00%> (ø)
sdk/src/metrics/meter.cc 88.21% <100.00%> (ø)

reyang
reyang approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Oct 5, 2020
@reyang reyang merged commit 7826040 into open-telemetry:master Oct 7, 2020
@reyang reyang mentioned this pull request Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxgolov maxgolov maxgolov approved these changes

@reyang reyang reyang approved these changes

@pyohannes pyohannes pyohannes approved these changes

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees
No one assigned
Labels
pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lalitb @ThomsonTan @pyohannes @reyang @maxgolov