feat: change source of packages from local feed to live npm/nuget feed #5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oser into benbrown/packagefeeds
…BotFramework-Composer into benbrown/packagefeeds
a-b-r-o-w-n
requested changes
Jan 14, 2021
hatpick
reviewed
Jan 14, 2021
|
@a-b-r-o-w-n @hatpick thanks for the great feedback. eagle eye as always! i addressed all the issues you pointed out and one or two others. |
a-b-r-o-w-n
reviewed
Jan 15, 2021
1 task
…oser into benbrown/packagefeeds
…BotFramework-Composer into benbrown/packagefeeds
|
@a-b-r-o-w-n ready to go i think! want to take one more look? |
a-b-r-o-w-n
approved these changes
Jan 19, 2021
alanlong9278
added a commit
that referenced
this pull request
Jan 25, 2021
* main: Update numberinput.dialog (#5575) fix hover display incorrect returntype (#5588) fix: Move persistence layer's delta computation into worker (#5563) fix: electron update error (#5573) fix: showing correct error message in local publish (#5509) feat: change source of packages from local feed to live npm/nuget feed (#5516) set max http header size to fix 431 (#5521) Updating to daily runtime for R12 development (#5529) fix: correctly generate l10n files when using zsh (#5555) chore: deprecate feature request issue template (#5378) fix: designPage navigation to settings Page url error (#5546) fix: luis\qna key missing in skill bot (#5545) delete trigger by projectId passed from projectTree (#5542)
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
microsoft#5516) * change source of feeds from local feed to live npm/nuget feed * fixes to formatting * update feed urls * Apply linting and prettification rules * address feedback from peers * remove unnecessary deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the package manager to use the npm and nuget search API rather than a static feed we hand-manage.
This currently uses these feeds:
For NPM, any package tagged
bf-component:https://registry.npmjs.org/-/v1/search?text=keywords:bf-component&size=100&from=0
For nuget, any package tagged
bf-component, including pre-release packages:https://azuresearch-usnc.nuget.org/query?q=Tags:%22bf-component%22&prerelease=true
Note: These feeds will be updated to search only Microsoft-published packages before we ship.
Also note: A follow-up PR will allow users to add their own feeds, search feeds, etc.
Task Item
Fixes #5484
To Do
bf-componentkeyword/tag