Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update numberinput.dialog #5575

Merged
merged 2 commits into from
Jan 25, 2021
Merged

fix: Update numberinput.dialog #5575

merged 2 commits into from
Jan 25, 2021

Conversation

xieofxie
Copy link
Contributor

@xieofxie xieofxie commented Jan 21, 2021 •
edited
Loading

Description

When playing around examples, I found this small bug.

Task Item

fixes #minor

Screenshots

@xieofxie
Update numberinput.dialog
8729dd1 
When playing around examples..
@coveralls
Copy link

coveralls commented Jan 21, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 55.048% when pulling 6dd34de on xieofxie-patch-1 into 46e1939 on main.

@xieofxie xieofxie changed the title Update numberinput.dialog fix: Update numberinput.dialog Jan 25, 2021
@xieofxie
Copy link
Contributor Author

xieofxie commented Jan 25, 2021 •
edited
Loading

Hello @luhan2017 I think we should fix the Security Analysis error:

[INFO] __________________________________________________________________________________________________________________ 
[INFO] |Legal Alerts                                                                                                    | 
[INFO] |________________________________________________________________________________________________________________| 
[INFO] |Alert title                             |Affected component                      |Severity                      | 
[INFO] |________________________________________|________________________________________|______________________________| 
[INFO] |GPL-3.0 requires legal review           |await-delay 1.0.0                       |High                          | 
[INFO] |________________________________________|________________________________________|______________________________| 
[INFO] |create-react-context requires legal review|create-react-context 0.2.3              |High                          | 
[INFO] |________________________________________|________________________________________|______________________________| 
[INFO] |electron requires legal review          |electron 8.2.4                          |High                          | 
[INFO] |________________________________________|________________________________________|______________________________| 
[INFO]  
##[warning]Component Governance detected 3 legal alerts. Microsoft’s Open Source policy requires that all legal issues found by this task be addressed by answering questions in the legal alert and completing necessary legal reviews through the Component Governance user experience. Visit https://aka.ms/cglegalalerts for more information.
[INFO]  
[INFO] __________________________________________________________________________________________________________________ 
[INFO] |Security Alerts                                                                                                 | 
[INFO] |________________________________________________________________________________________________________________| 
[INFO] |Alert title                             |Affected component                      |Severity                      | 
[INFO] |________________________________________|________________________________________|______________________________| 
[INFO] |CVE-2020-28477                          |immer 1.10.0                            |High                          | 
[INFO] |________________________________________|________________________________________|______________________________| 
[INFO] |CVE-2020-28477                          |immer 5.2.0                             |High                          | 
[INFO] |________________________________________|________________________________________|______________________________| 
[INFO] 
##[error]Component Governance failed due to the presence of 2 security alerts at or above 'High' severity. Microsoft’s Open Source policy requires that all high and critical security vulnerabilities found by this task be addressed by upgrading vulnerable components. Vulnerabilities in indirect dependencies should be addressed by upgrading the root dependency.

@xieofxie xieofxie merged commit 837a7dd into main Jan 25, 2021
@xieofxie xieofxie deleted the xieofxie-patch-1 branch January 25, 2021 10:06
alanlong9278 added a commit that referenced this pull request Jan 25, 2021
@alanlong9278
Merge branch 'main' into julong/keyboard-err
40d4641 
* main:
  Update numberinput.dialog (#5575)
  fix hover display incorrect returntype (#5588)
  fix: Move persistence layer's delta computation into worker (#5563)
  fix: electron update error (#5573)
  fix: showing correct error message in local publish (#5509)
  feat: change source of packages from local feed to live npm/nuget feed (#5516)
  set max http header size to fix 431 (#5521)
  Updating to daily runtime for R12 development (#5529)
  fix: correctly generate l10n files when using zsh (#5555)
  chore: deprecate feature request issue template (#5378)
  fix: designPage navigation to settings Page url error (#5546)
  fix: luis\qna key missing in skill bot (#5545)
  delete trigger by projectId passed from projectTree (#5542)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@xieofxie
Update numberinput.dialog (microsoft#5575)
5f1f368 
When playing around examples..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@luhan2017 luhan2017 luhan2017 approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@cwhitten cwhitten Awaiting requested review from cwhitten

Assignees

@boydc2014 boydc2014

@luhan2017 luhan2017

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xieofxie @coveralls @boydc2014 @luhan2017