Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hover on pre-built functions displays incorrect ReturnType content #5588

Merged
merged 3 commits into from
Jan 25, 2021

Conversation

cosmicshuai
Copy link
Contributor

@cosmicshuai cosmicshuai commented Jan 22, 2021

Fixes #5332
Currently, LG editor displayed incorrect ReturnType when user hover on pre-built functions.
In this PR, the value of ReturnType will be mapped to its explicit content.
image

@cosmicshuai cosmicshuai changed the title Fix hover on pre-built functions displays incorrect ReturnType content Fix: hover on pre-built functions displays incorrect ReturnType content Jan 22, 2021
@hatpick hatpick changed the title Fix: hover on pre-built functions displays incorrect ReturnType content fix: hover on pre-built functions displays incorrect ReturnType content Jan 22, 2021
@coveralls
Copy link

coveralls commented Jan 22, 2021

Coverage Status

Coverage decreased (-0.02%) to 55.048% when pulling 3e2949f on shuwan/fixReturnTypeDisplay into 221dcec on main.

@cosmicshuai cosmicshuai merged commit 46e1939 into main Jan 25, 2021
@cosmicshuai cosmicshuai deleted the shuwan/fixReturnTypeDisplay branch January 25, 2021 05:32
alanlong9278 added a commit that referenced this pull request Jan 25, 2021
* main:
  Update numberinput.dialog (#5575)
  fix hover display incorrect returntype (#5588)
  fix: Move persistence layer's delta computation into worker (#5563)
  fix: electron update error (#5573)
  fix: showing correct error message in local publish (#5509)
  feat: change source of packages from local feed to live npm/nuget feed (#5516)
  set max http header size to fix 431 (#5521)
  Updating to daily runtime for R12 development (#5529)
  fix: correctly generate l10n files when using zsh (#5555)
  chore: deprecate feature request issue template (#5378)
  fix: designPage navigation to settings Page url error (#5546)
  fix: luis\qna key missing in skill bot (#5545)
  delete trigger by projectId passed from projectTree (#5542)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement of LG and LU editing experience
3 participants