Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly generate l10n files when using zsh #5555

Merged
merged 1 commit into from
Jan 19, 2021
Merged

fix: correctly generate l10n files when using zsh #5555

merged 1 commit into from
Jan 19, 2021

Conversation

a-b-r-o-w-n
Copy link
Contributor

Description

Some zsh configurations will expand glob patterns resulting in format-message only executing on the first argument.

Task Item

#minor

@a-b-r-o-w-n a-b-r-o-w-n merged commit 0b88e0b into main Jan 19, 2021
@a-b-r-o-w-n a-b-r-o-w-n deleted the abrown/l10n-script branch January 19, 2021 22:17
@coveralls
Copy link

Coverage Status

Coverage remained the same at 55.086% when pulling 189c4e6 on abrown/l10n-script into 67931eb on main.

alanlong9278 added a commit that referenced this pull request Jan 25, 2021
@alanlong9278
Merge branch 'main' into julong/keyboard-err
40d4641 
* main:
  Update numberinput.dialog (#5575)
  fix hover display incorrect returntype (#5588)
  fix: Move persistence layer's delta computation into worker (#5563)
  fix: electron update error (#5573)
  fix: showing correct error message in local publish (#5509)
  feat: change source of packages from local feed to live npm/nuget feed (#5516)
  set max http header size to fix 431 (#5521)
  Updating to daily runtime for R12 development (#5529)
  fix: correctly generate l10n files when using zsh (#5555)
  chore: deprecate feature request issue template (#5378)
  fix: designPage navigation to settings Page url error (#5546)
  fix: luis\qna key missing in skill bot (#5545)
  delete trigger by projectId passed from projectTree (#5542)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@a-b-r-o-w-n
fix: correctly generate l10n files when using zsh (microsoft#5555)
c350d1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatpick hatpick hatpick approved these changes

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@hatpick hatpick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-b-r-o-w-n @coveralls @hatpick