Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 431 error when publish #5521

Merged
merged 5 commits into from
Jan 20, 2021
Merged

fix: 431 error when publish #5521

merged 5 commits into from
Jan 20, 2021

Conversation

VanyLaw
Copy link
Contributor

@VanyLaw VanyLaw commented Jan 14, 2021

Description

fix 431 header too large error when publishing by setting max http header size in server.

Task Item

close #5467

Screenshots

Use user's token to test, won't return 431.
image

@coveralls
Copy link

coveralls commented Jan 14, 2021

Coverage Status

Coverage decreased (-0.01%) to 55.086% when pulling 9da7273 on wenyluo/fixHeader into ecf2df0 on main.

@yeze322
Copy link
Contributor

yeze322 commented Jan 20, 2021

Shall we take this fix in the patch release? @cwhitten @boydc2014
It causes the bot cannot be published to Azure

@luhan2017 luhan2017 merged commit df53a98 into main Jan 20, 2021
@luhan2017 luhan2017 deleted the wenyluo/fixHeader branch January 20, 2021 04:20
@tiagonmas
Copy link

tiagonmas commented Jan 20, 2021

I installed the nightly build df53a98 and still get the error
image

@slymuffhugger
Copy link

Also getting error after installing nightly build

@cwhitten
Copy link
Member

@tiagonmas & @kalebk can you please try the following:

  1. Open a shell (cmd, etc)
  2. Insert the following environment variable & value into the shell: DEBUG=composer*
  3. Start Composer from the shell process

This should start Composer normally with additional logging to the server's stdout. After doing this can you run through the Provisioning experience again and paste the logs you see when running into this error?

@tiagonmas
Copy link

tiagonmas commented Jan 20, 2021

Hi,
Here is the output:

(electron) The default value of app.allowRendererProcessReuse is deprecated, it is currently "false".  It will change to be "true" in Electron 9.  For more information please check https://github.com/electron/electron/issues/18397
Wed, 20 Jan 2021 15:46:11 GMT express-session deprecated undefined resave option; provide resave option at AppData\Local\Programs\Bot Framework Composer\resources\app.asar\node_modules\@bfc\server\build\server.js:48:17
Wed, 20 Jan 2021 15:46:11 GMT express-session deprecated undefined saveUninitialized option; provide saveUninitialized option at AppData\Local\Programs\Bot Framework Composer\resources\app.asar\node_modules\@bfc\server\build\server.js:48:17Warning: connect.session() MemoryStore is not
designed for a production environment, as it will leak
memory, and will not scale past a single process.
(node:24796) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(node:24796) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.


Composer now running at:

http://localhost:5000

GET / 200 9.486 ms - 899
Checking for update
GET /api/extensions 304 4.473 ms - -
GET /api/featureFlags 304 2.685 ms - -
GET /api/assets/locales/en-US.json 200 22.933 ms - -
GET /api/storages 304 0.782 ms - -
GET /api/assets/projectTemplates 304 0.825 ms - -
GET /api/projects/recent 304 6.568 ms - -
GET /api/storages/default/blobs?path=C%253A%252FTiago%252FProjects%252Fbotcomposer%252Fecho 304 15.548 ms - -
Update for version 1.3.1-nightly.204049.df53a98 is not available (latest version: 1.3.1-nightly.204049.df53a98, downgrade is disallowed).
POST /api/telemetry/events 200 6.050 ms - 2
PUT /api/projects/open 200 663.212 ms - -
GET /api/publish/39162.04744549128/status/default 404 377.666 ms - 66
PUT /api/projects/39162.04744549128/files/TasEchoBot.botproj 200 435.951 ms - 85
PUT /api/projects/39162.04744549128/files/appsettings.json 200 417.455 ms - 34
GET /api/storages 304 0.999 ms - -
GET /api/storages/default/blobs?path=C%253A%252FTiago%252FProjects%252Fbotcomposer%252Fecho 304 9.159 ms - -
GET /api/assets/projectTemplates 304 0.446 ms - -
GET /api/storages/default/blobs?path=C%253A%252FTiago%252FProjects%252Fbotcomposer%252Fecho 304 4.301 ms - -
POST /api/telemetry/events 200 1.642 ms - 2
GET /api/publish/types 304 0.767 ms - -
POST /api/telemetry/events 200 1.271 ms - 2
GET /api/runtime/templates 304 0.493 ms - -
GET /api/publish/types 304 0.452 ms - -
GET /api/projects/39162.04744549128/boilerplateVersion 304 274.927 ms - -
GET /plugin-host.html 200 3.098 ms - 997
GET /api/extensions/azurePublish/azurePublish 304 2.564 ms - -
OneAuth Version 1.15.0 (com.microsoft.BotFrameworkComposer)
[OneAuth:Warning:9a8hm:d8e8af45-2cda-48cd-a92e-8f0e4aa8a40b] HTTP status: 403
[OneAuth:Warning:9a8hm:d8e8af45-2cda-48cd-a92e-8f0e4aa8a40b] HTTP status: 403
[OneAuth:Error:835v1:d8e8af45-2cda-48cd-a92e-8f0e4aa8a40b] (Code:2001) The resource is forbidden.
[OneAuth:Error:835v1:d8e8af45-2cda-48cd-a92e-8f0e4aa8a40b] (Code:2001) The resource is forbidden.
[OneAuth:Warning:96w1t:d8e8af45-2cda-48cd-a92e-8f0e4aa8a40b] Failed to get profile image from Graph
[OneAuth:Warning:96w1t:d8e8af45-2cda-48cd-a92e-8f0e4aa8a40b] Failed to get profile image from Graph
GET /api/auth/getAccessToken?targetResource=https%3A%2F%2Fmanagement.core.windows.net%2F 200 46412.608 ms - -
GET /api/provision/39162.04744549128/azurePublish/resources 304 283.892 ms - -
GET /api/auth/getAccessToken?targetResource=https%3A%2F%2Fmanagement.core.windows.net%2F 304 0.398 ms - -
GET /api/auth/getAccessToken?targetResource=https%3A%2F%2Fgraph.microsoft.com%2F 200 571.478 ms - -
POST /api/telemetry/events 200 0.834 ms - 2

@luhan2017
Copy link
Contributor

@tiagonmas we just found the change on this PR will not take effect in electron app. could you try to set this environment variable before start the nightly composer build, and try again?

NODE_OPTIONS="--max-http-header-size=16000"

@tiagonmas
Copy link

@luhan2017 it worked with that setting! :)
image

alanlong9278 added a commit that referenced this pull request Jan 25, 2021
* main:
  Update numberinput.dialog (#5575)
  fix hover display incorrect returntype (#5588)
  fix: Move persistence layer's delta computation into worker (#5563)
  fix: electron update error (#5573)
  fix: showing correct error message in local publish (#5509)
  feat: change source of packages from local feed to live npm/nuget feed (#5516)
  set max http header size to fix 431 (#5521)
  Updating to daily runtime for R12 development (#5529)
  fix: correctly generate l10n files when using zsh (#5555)
  chore: deprecate feature request issue template (#5378)
  fix: designPage navigation to settings Page url error (#5546)
  fix: luis\qna key missing in skill bot (#5545)
  delete trigger by projectId passed from projectTree (#5542)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem publishing
8 participants