Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make it possible to search nuget/npm and compatible feeds #5537

Closed
wants to merge 18 commits into from

Conversation

benbrown
Copy link
Contributor

@benbrown benbrown commented Jan 15, 2021

Description

This PR allows a feed source to be searched, either by providing a search URL, or by local filtering.

Each feed record can provide a searchUrl field. This is not mandatory and not something we need to expose to users. If specified, when a search term is provided, the search URL will be used to load packages. If searchUrl is not present, composer will load all items and filter by the search term using the name, description and keyword list.

This will allow users to search npm or nuget with or without tags, keywords, etc. IT can also be used to search private nuget feeds. And even static feeds without search features can also be searched. Magic.

Note this is branched from #5516, merge that one first.

Task Item

Fixes #5485

Screenshots

VquaMRjKBu

Todo:

  • Implement final UX

@coveralls
Copy link

coveralls commented Jan 15, 2021

Coverage Status

Coverage remained the same at 55.086% when pulling 094373e on benbrown/searchfeeds into 1aa2c8a on main.

@benbrown benbrown closed this Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package Manager: Search npm/nuget
2 participants