-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make it possible to search nuget/npm and compatible feeds #5537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oser into benbrown/packagefeeds
…BotFramework-Composer into benbrown/packagefeeds
…oser into benbrown/packagefeeds
…BotFramework-Composer into benbrown/packagefeeds
…oser into benbrown/searchfeeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows a feed source to be searched, either by providing a search URL, or by local filtering.
Each feed record can provide a searchUrl field. This is not mandatory and not something we need to expose to users. If specified, when a search term is provided, the search URL will be used to load packages. If searchUrl is not present, composer will load all items and filter by the search term using the name, description and keyword list.
This will allow users to search npm or nuget with or without tags, keywords, etc. IT can also be used to search private nuget feeds. And even static feeds without search features can also be searched. Magic.
Note this is branched from #5516, merge that one first.
Task Item
Fixes #5485
Screenshots
Todo: