testing PR #9
Open
testing PR #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jia Hao <thao@wish.com>
Signed-off-by: Kateryna Nezdolii <nezdolik@spotify.com>
Signed-off-by: Kateryna Nezdolii <nezdolik@spotify.com>
Signed-off-by: Tong Cai <caitong93@gmail.com>
The underlying memcache client library allows this to be configured, and currently defaults to a value of 2, see: https://github.com/bradfitz/gomemcache/blob/master/memcache/memcache.go#L72 https://github.com/bradfitz/gomemcache/blob/master/memcache/memcache.go#L145 https://github.com/bradfitz/gomemcache/blob/master/memcache/memcache.go#L239 This allows this value to be configured by a new environmet variable: MEMCACHE_MAX_IDLE_CONNS which defaults to -1 meaning the default from the library will apply (which is the current behaviour). Signed-off-by: Peter Marsh <pete.d.marsh@gmail.com>
Signed-off-by: devincd <505259926@qq.com>
Signed-off-by: Peter Marsh <pete.d.marsh@gmail.com>
- servers listen addresses are configurable via environment variable - matches port configurability providing *HOST environment variables Fixes #245 Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
User deferred barrier.signal() so panic definitely occurs before we continue on in test. Config reload uses recover() and increments config load counter, tests were failing to see config load error counter increment. Fixes: #256 Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
This allows MEMCAHE_SRV to be specified as an SRV record from
which multiple memcache hosts can be resolved. For example:
MEMCACHE_SRV=_memcache._tcp.mylovelydomain.com
This can be used instead of MEMCACHE_HOST_PORT.
This will then be resolved and whatever set of servers it represents
will be used as the set of memcache servers to connect to. At this
stage neither priority or weight is supported, though weight could
be fairly straightforwardly in future.
The SRV can be polled periodically for new servers by setting the
following env var (with 0 meaning "never check"):
MEMCACHE_SRV_REFRESH=600s # supports standard go durations
Signed-off-by: Peter Marsh <pete.d.marsh@gmail.com>
…ve them to goroutines pool (#251) Signed-off-by: bstorozhuk <storozhuk.b.m@gmail.com>
Signed-off-by: Pablo Radnic <pradnic@medallia.com>
Signed-off-by: lmajercak-wish <lmajercak@wish.com>
Signed-off-by: devincd <505259926@qq.com>
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: devincd <505259926@qq.com>
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Javier Ruiz Arduengo <javier@squareup.com>
* Add configurable GrpcMaxConnectionAge, GrpcMaxConnectionAgeGrace Signed-off-by: lmajercak-wish <lmajercak@wish.com> * Add configurable GrpcMaxConnectionAge, GrpcMaxConnectionAgeGrace Signed-off-by: lmajercak-wish <lmajercak@wish.com> * Fix fmt Signed-off-by: lmajercak-wish <lmajercak@wish.com> * Add to README Signed-off-by: lmajercak-wish <lmajercak@wish.com> * Fix README format Signed-off-by: lmajercak-wish <lmajercak@wish.com>
This did not work in practice due to a mix up of
func example(serverList memcache.ServerList)
and
func example(serverList *memcache.ServerList)
The code used the first case and did not correctly update a given
memcache.ServerList instance, instead a new one was created, updated
then forgot.
Signed-off-by: Peter Marsh <pmarsh@spotify.com>
#292) * Addressing issue #291 - Adding custom headers with the ratelimit triggered Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Fixing doc format Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Fixing data race condition during config-reload Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Review comments Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Review comments Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Changed settings approach. Refactored custom clock to use already existing TimeSource Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Cleanup after timesource refactoring Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Fixed review comments Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> Co-authored-by: Jesper Söderlund <jesper.soderlund@klarna.com>
* Global ShadowMod Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Adding shadow-mode issue #293 Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Fix doc format Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Extended example to showcase shadow mode as well, build a docker image with the current rate limit, extend envoy config to display rate limit headers. Extend statsd to show shadow mode Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Fine tuning of docs and example Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Added integration tests, fixed some review comments Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * Doc format fix Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> * gitignore for vscode Signed-off-by: Jesper Söderlund <jesper.soderlund@klarna.com> Co-authored-by: Jesper Söderlund <jesper.soderlund@klarna.com>
* Add pre-commit linters, formatters Signed-off-by: Yuki Sawa <yukisawa@gmail.com> * add descriptive name for fail msg step Signed-off-by: Yuki Sawa <yukisawa@gmail.com> * shorten precommit makefile cmd Signed-off-by: Yuki Sawa <yukisawa@gmail.com> * make fix_format Signed-off-by: Yuki Sawa <yukisawa@gmail.com> * autoformat all lint errs Signed-off-by: Yuki Sawa <yukisawa@gmail.com> * backtick quote to avoid formatter Signed-off-by: Yuki Sawa <yukisawa@gmail.com> * add shfmt for bash linting Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
* Do not panic on debug /rlconfig if no config loaded Signed-off-by: James Fish <jfish@pinterest.com> * Format Signed-off-by: James Fish <jfish@pinterest.com> * Collapse if Signed-off-by: James Fish <jfish@pinterest.com>
Signed-off-by: debbyku <debbyku.2008@gmail.com>
Signed-off-by: Peter Marsh <pete.d.marsh@gmail.com>
* health check failed if no active redis connection Signed-off-by: debbyku <debbyku.2008@gmail.com> * solve redis connection active count error Signed-off-by: debbyku <debbyku.2008@gmail.com>
…pc/otelgrpc (#672) Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.52.0 to 0.53.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.52.0...zpages/v0.53.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.3.6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b2256b...834a144) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from 1.22.5 to 1.22.6. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from 1.22.5 to 1.22.6. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.15 to 3.26.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@afb54ba...eb055d7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.1 to 5.0.2. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@cdcb360...0a12ed9) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.5.0 to 3.6.1. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@aa33708...988b5a0) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.3 to 2.4.0. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@dc50aa9...62b2cac) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Bumps alpine from 3.20.2 to 3.20.3. --- updated-dependencies: - dependency-name: alpine dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps alpine from `0a4eaa0` to `1e42bbe`. --- updated-dependencies: - dependency-name: alpine dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps alpine from `beefdbd` to `1e42bbe`. --- updated-dependencies: - dependency-name: alpine dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from 1.22.6 to 1.23.3. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from 1.22.6 to 1.23.3. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.0 to 3.27.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@eb055d7...f09c1c0) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from `d56c3e0` to `73f06be`. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from `d56c3e0` to `73f06be`. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.1.1 to 5.3.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@39cd149...0b93645) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Rico Pahlisch <pahli88@googlemail.com> Signed-off-by: Rico Pahlisch <rico.pahlisch@grayc.de>
* 365 days in a year, not 356 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: zirain <zirain2009@gmail.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.26.0 to 0.33.0. - [Commits](golang/net@v0.26.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ratelimit: per descriptor hits addend support and prefer uint64 Signed-off-by: wangbaiping/wbpcode <wangbaiping@bytedance.com> * fix some tests Signed-off-by: wangbaiping/wbpcode <wangbaiping@bytedance.com> * refactor and fix Signed-off-by: wangbaiping/wbpcode <wangbaiping@bytedance.com> * more different tests Signed-off-by: wangbaiping/wbpcode <wangbaiping@bytedance.com> * remove max Signed-off-by: wangbaiping/wbpcode <wangbaiping@bytedance.com> --------- Signed-off-by: wangbaiping/wbpcode <wangbaiping@bytedance.com>
* Add configuration CONFIG_GRPC_XDS_SERVER_CONNECT_RETRY_INTERVAL Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com> * Update configuration name Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com> --------- Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Stefan Sedich <stefan.sedich@gmail.com>
* chore: replace dots in ipv4 addresses with slashes Signed-off-by: Rolf Ahrenberg <rolf.ahrenberg@saunalahti.fi> * chore: tweak default mapper configuration for Prometheus Signed-off-by: Rolf Ahrenberg <rolf.ahrenberg@saunalahti.fi> --------- Signed-off-by: Rolf Ahrenberg <rolf.ahrenberg@saunalahti.fi>
Bumps golang from 1.23.3 to 1.23.5. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps golang from 1.23.3 to 1.23.5. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.