Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix go-fumpt args #694

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix go-fumpt args #694

merged 1 commit into from
Dec 3, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Sep 2, 2024

follow up: #664 (review)

@zirain
fix go-fumpt args
bd7b5c1 
Signed-off-by: zirain <zirain2009@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 2, 2024
@zirain
Copy link
Member Author

zirain commented Oct 2, 2024

@mattklein123 PTAL

@github-actions github-actions bot removed the stale label Oct 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 2, 2024
@zirain
Copy link
Member Author

zirain commented Nov 2, 2024

not stale

@github-actions github-actions bot removed the stale label Nov 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 2, 2024
arkodg
arkodg approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg
Copy link
Contributor

arkodg commented Dec 3, 2024

cc @collin-lee @psbrar99

@github-actions github-actions bot removed the stale label Dec 3, 2024
@collin-lee collin-lee merged commit 738fdce into envoyproxy:main Dec 3, 2024
6 checks passed
@zirain zirain deleted the go-fumpt branch December 3, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkodg arkodg arkodg approved these changes

@collin-lee collin-lee collin-lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zirain @arkodg @collin-lee