Add configurable GrpcMaxConnectionAge, GrpcMaxConnectionAgeGrace #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lmajercak-wish <lmajercak@wish.com>
Signed-off-by: lmajercak-wish <lmajercak@wish.com>
6a56f0c to
e150dae
Compare
…xtLogic/ratelimit into lmajercak_grpc_connection_settings
|
Changes makes sense to me. Could you add docs about the new settings in the README and maybe some simple tests? Thanks! |
Signed-off-by: lmajercak-wish <lmajercak@wish.com>
Added to the README. What are you thinking for the unit test? |
Signed-off-by: lmajercak-wish <lmajercak@wish.com>
ysawa0
approved these changes
Sep 10, 2021
|
I was going to suggest adding a simple integration test but it's already being tested via the default values so I guess this is fine. The defaults look sane as well. Will go ahead and merge, thanks! |
timcovar
pushed a commit
to goatapp/ratelimit
that referenced
this pull request
Jan 16, 2024
…oyproxy#288) * Add configurable GrpcMaxConnectionAge, GrpcMaxConnectionAgeGrace Signed-off-by: lmajercak-wish <lmajercak@wish.com> * Add configurable GrpcMaxConnectionAge, GrpcMaxConnectionAgeGrace Signed-off-by: lmajercak-wish <lmajercak@wish.com> * Fix fmt Signed-off-by: lmajercak-wish <lmajercak@wish.com> * Add to README Signed-off-by: lmajercak-wish <lmajercak@wish.com> * Fix README format Signed-off-by: lmajercak-wish <lmajercak@wish.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server-side configuration of MaxConnectionAge, MaxConnectionAgeGrace is needed to achieve better load balancing behavior in auto-scaled scenarios: grpc/grpc#12295 (comment)