Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug and code optimization #273

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Fix bug and code optimization #273

merged 2 commits into from
Jul 29, 2021

Conversation

devincd
Copy link
Contributor

@devincd devincd commented Jul 28, 2021

Signed-off-by: devincd 505259926@qq.com

If redis url is unix domain socket, will panic. The log is bellow:

WARN[0000] connecting to redis on /var/run/nutcracker/ratelimit.sock with pool size 10
panic: dial tcp: address /var/run/nutcracker/ratelimit.sock: missing port in address

@devincd
fix bug
4d34af1 
Signed-off-by: devincd <505259926@qq.com>
mattklein123
mattklein123 reviewed Jul 28, 2021
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. One question.

/wait-any

src/server/server_impl.go
server.httpServer.Close()
}
server.listenerMu.Unlock()
os.Exit(0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave the Exit(0) call after the Stop() call? Is it not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. it is needed

@mattklein123 mattklein123 self-assigned this Jul 28, 2021
@devincd
add os.Exit(0) after call stop()
c5bd2a4 
Signed-off-by: devincd <505259926@qq.com>
mattklein123
mattklein123 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 73ad2b3 into envoyproxy:main Jul 29, 2021
@devincd devincd deleted the code_optimization branch July 30, 2021 01:31
timcovar pushed a commit to goatapp/ratelimit that referenced this pull request Jan 16, 2024
@devincd @timcovar
Fix bug and code optimization (envoyproxy#273)
b7ea912 
Signed-off-by: devincd <505259926@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees

@mattklein123 mattklein123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devincd @mattklein123