Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis: update doc #240

Merged
merged 3 commits into from
Mar 30, 2021
Merged

redis: update doc #240

merged 3 commits into from
Mar 30, 2021

Conversation

caitong93
Copy link
Contributor

Improve documentation for REDIS_PIPELINE_WINDOW and REDIS_PIPELINE_LIMIT for better understanding.
Also fix a bug that per second redis use REDIS_PIPELINE_WINDOW/REDIS_PIPELINE_LIMIT rather than RedisPerSecondPipelineWindow/RedisPerSecondPipelineLimit.

…INE_LIMIT.

Signed-off-by: Tong Cai <caitong93@gmail.com>
…S_PIPELINE_LIMIT rather than RedisPerSecondPipelineWindow/RedisPerSecondPipelineLimit

Signed-off-by: Tong Cai <caitong93@gmail.com>
Signed-off-by: Tong Cai <caitong93@gmail.com>
@mattklein123 mattklein123 self-assigned this Mar 30, 2021
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit c03723f into envoyproxy:main Mar 30, 2021
zdmytriv pushed a commit to verygoodsecurity/ratelimit that referenced this pull request Aug 2, 2021
timcovar pushed a commit to goatapp/ratelimit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants