Add server-side metrics #236
Conversation
Signed-off-by: Jia Hao <thao@wish.com>
Signed-off-by: Jia Hao <thao@wish.com>
| name: "ratelimit_service_total_requests" | ||
| match_metric_type: counter | ||
| - match: "ratelimit_server.response_time" | ||
| name: "ratelimit_service_response_time_seconds" |
There was a problem hiding this comment.
s.responseTime.AddValue(float64(time.Since(start).Milliseconds())) is this in milliseconds or seconds ?
There was a problem hiding this comment.
According to the statsd exporter statsd format is milliseconds and prometheus format is seconds, so the exporter will convert the timer value to seconds.
Signed-off-by: Jia Hao <thao@wish.com>
Signed-off-by: Jia Hao <thao@wish.com>
Signed-off-by: Jia Hao <thao@wish.com>
| func newServerMetrics(scope stats.Scope, fullMethod string) *serverMetrics { | ||
| _, methodName := splitMethodName(fullMethod) | ||
| ret := serverMetrics{} | ||
| ret.totalRequests = scope.NewCounter(methodName + ".total_requests") |
There was a problem hiding this comment.
I know the existing code tends to use metric names rather than tags, but for what its worth: I'd much rather see methodName as a tag rather than part of the metric name. (More generally, it seems like there's little to no reason a metric name ever needs to be dynamically created in a system that supports metrics with tags)
Using tags makes it simple in most metric systems to aggregate stats across method names or break down to specific subsets of method names.
Aggregating across metric names, by contrast, is not particularly simple or normal or standard in most metrics systems. Using different metric names also makes discovering what metric exist by looking at metric names a mess.
There was a problem hiding this comment.
I agree that metrics tags are always the better choice than embedding in metrics name, but I don't think prom-statsd exporter supports the tagging format used by gostats. (please correct me if I'm wrong) So we'll have to do regexp matching to export it as a prom label, which is slower and more work than using glob patterns.
If there is a quick and easy way to export tags as prom labels, I'm happy to use tags instead.
Signed-off-by: Jia Hao <thao@wish.com>
Signed-off-by: Jia Hao <thao@wish.com>
Add server-side metrics #234