Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta update #8627

Merged
merged 3 commits into from
Dec 16, 2023
Merged

beta update #8627

merged 3 commits into from
Dec 16, 2023

Conversation

@yangwao yangwao added the beta label Dec 16, 2023
Copy link

netlify bot commented Dec 16, 2023

Deploy Preview for koda-beta ready!

Name Link
🔨 Latest commit 45606d3
🔍 Latest deploy log https://app.netlify.com/sites/koda-beta/deploys/657dbbf2034eeb00088717e9
😎 Deploy Preview https://deploy-preview-8627--koda-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yangwao yangwao marked this pull request as ready for review December 16, 2023 15:02
@yangwao yangwao requested a review from a team as a code owner December 16, 2023 15:02
@yangwao yangwao requested review from preschian and daiagi and removed request for a team December 16, 2023 15:02
@yangwao yangwao merged commit f9bc63a into beta Dec 16, 2023
Copy link
Contributor

reviewpad bot commented Dec 16, 2023

AI-Generated Summary: This pull request introduces a fix to the issue of the drop modal getting stuck. It modifies code in three files: AddFundsModal.vue, AutoTeleportActionButton.vue, anduseAutoTeleportTransitionDetails.ts.

The changes in AddFundsModal.vue and AutoTeleportActionButton.vue modify the loading and showAddFunds computed properties to rely on isReady, respectively, rather than on hasBalances status.

In useAutoTeleportTransitionDetails.ts, the fetched ref's structure is updated to include a balances property. The computation of the hasBalances variable is modified to consider not just the presence of balances, but whether this data is fetched. Also, the asynchronous functionality of loading the transition balances now uses the fetched ref's balances property to indicate the start and end of the loading process.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Dec 16, 2023
Copy link
Contributor

reviewpad bot commented Dec 16, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link

netlify bot commented Dec 16, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 45606d3
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/657dbbf2027f34000859bf27
😎 Deploy Preview https://deploy-preview-8627--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants