Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💙 new drop #8553

Merged
merged 5 commits into from
Dec 13, 2023
Merged

💙 new drop #8553

merged 5 commits into from
Dec 13, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Dec 13, 2023 •
edited by ghost
Loading

  • ⚡ show whirls and chroma in landing
  • 🔧 new drop is whirls

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • The ususal

Context

New drop is Whirls

Did your issue had any of the "$" label on it?

Copilot Summary

🤖[deprecated] Generated by Copilot at 686db40

This pull request updates the generative NFTs carousel and the Whirls collection page. It adds more collection ids to the useCarouselGenerativeNftEvents function in CarouselTypeGenerative.vue and changes the nuxt-link component in UnlockableLandingTag.vue to match the new collection name and URL.

🤖[deprecated] Generated by Copilot at 686db40

useCarousel adds
more collections to display
diverse NFTs shine

@vikiival vikiival requested a review from a team as a code owner December 13, 2023 14:56
@vikiival vikiival requested review from daiagi and Jarsen136 and removed request for a team December 13, 2023 14:56
@netlify Netlify
Copy link

netlify bot commented Dec 13, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit fb89dce
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6579d27b76c1510008cf685a
😎 Deploy Preview https://deploy-preview-8553--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 13, 2023
@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Dec 13, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad Reviewpad
Copy link
Contributor

reviewpad bot commented Dec 13, 2023

AI-Generated Summary: This pull request consists of two parts:

  • The first patch modifies the CarouselTypeGenerative.vue file. It changes the parameters passed to the useCarouselGenerativeNftEvents function by adding the elements '51' and '52' to the existing array ['38', '40', '46', '49', '50'].

  • The second patch modifies the UnlockableLandingTag.vue file. It changes the hyperlink in the NuxtLink component from "/ahp/drops/wallstreet" to "/ahp/drops/whirls".

This means that the carousel will now also show assets associated with IDs 51 and 52, and the landing tag navigation will route to the 'whirls' drop instead of the 'wallstreet' drop.

roiLeo
roiLeo approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link #8538

@Jarsen136
Copy link
Contributor

link #8538

Let's merge this one first

@vikiival
🐛 pPlease also update
6ee0443
@vikiival
Merge remote-tracking branch 'origin/main' into drooop
99adb37 
# Conflicts:
#	components/carousel/CarouselTypeGenerative.vue
#	components/collection/unlockable/UnlockableLandingMobileBanner.vue
#	components/collection/unlockable/UnlockableLandingTag.vue
@vikiival
🔧 new drops
fb89dce
@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 13, 2023

Code Climate has analyzed commit fb89dce and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikiival
Copy link
Member Author

Updated in fb89dce

@vikiival vikiival added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit 875867b Dec 13, 2023
@vikiival vikiival deleted the drooop branch December 13, 2023 21:06
This was referenced Dec 14, 2023
Merged
Merged
Merged
Merged
This was referenced Dec 15, 2023
Merged
Merged
This was referenced Dec 16, 2023
Closed
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vikiival @Jarsen136 @roiLeo @prury