Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NeoTable content dark mode #8534

Merged
merged 2 commits into from
Dec 14, 2023
Merged

fix: NeoTable content dark mode #8534

merged 2 commits into from
Dec 14, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Dec 11, 2023

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2023-12-11 at 16 08 56@2x

Copilot Summary

🤖[deprecated] Generated by Copilot at 386f657

Fixed hoverable style bug in NeoTable component. Added a class to inherit table background color and applied hover effect to table cells.

🤖[deprecated] Generated by Copilot at 386f657

NeoTable rows
inherit background color
cut by hover style

@hassnian hassnian requested a review from a team as a code owner December 11, 2023 11:09
@hassnian hassnian requested review from vikiival and removed request for a team December 11, 2023 11:09
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 808913c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/657887959c2b81000887b871
😎 Deploy Preview https://deploy-preview-8534--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Dec 11, 2023

WARNING @hassnian PR for issue #8525 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8525

Copy link
Contributor

reviewpad bot commented Dec 11, 2023

AI-Generated Summary: This pull request includes a fix for the dark mode on mobile for the NeoTable component. It modifies the CSS in the NeoTable.vue file. The major change focuses on the hoverable state of the table rows. The background color has been modified to 'inherit' when not in hover state, but retains the 'bg-k-accent-light-2' when on hover. This has been done to ensure better compatibility and appearance in dark mode on mobile devices.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 11, 2023
@vikiival vikiival requested review from roiLeo and shashkovdanil and removed request for vikiival December 11, 2023 11:38
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 11, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use class props when possible or sass variable

✅ wfm

@roiLeo roiLeo enabled auto-merge December 12, 2023 16:17
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Dec 12, 2023

Code Climate has analyzed commit 808913c and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo roiLeo requested a review from daiagi December 13, 2023 07:44
@roiLeo roiLeo added this pull request to the merge queue Dec 14, 2023
Merged via the queue into kodadot:main with commit 3efdd10 Dec 14, 2023
@hassnian hassnian deleted the issue-8525 branch December 14, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NeoTable content dark mode
5 participants