Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick fixes drop #8599

Merged
merged 3 commits into from
Dec 15, 2023
Merged

quick fixes drop #8599

merged 3 commits into from
Dec 15, 2023

Conversation

vikiival
Copy link
Member

  • 🌐 not free drop
  • 🐛 should not be there

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

@vikiival vikiival requested a review from a team as a code owner December 15, 2023 14:35
@vikiival vikiival requested review from roiLeo and Jarsen136 and removed request for a team December 15, 2023 14:35
Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4c0d418
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/657c6449adafdc0008f1054b
😎 Deploy Preview https://deploy-preview-8599--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 15, 2023
Copy link
Contributor

reviewpad bot commented Dec 15, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link

codeclimate bot commented Dec 15, 2023

Code Climate has analyzed commit 4c0d418 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

reviewpad bot commented Dec 15, 2023

AI-Generated Summary: This pull request consists of two major changes:

  1. An update to the 'locales/en.json' file, specifically revising the 'minimumFundsDescription'. The requirement text regarding a free mint has been modified. The new change implies that holding a minimum amount in your wallet is mandatory, but it doesn't necessarily grant a free mint.

  2. A modification in 'components/collection/drop/HolderOfGenerative.vue' file where a redundant function call 'submitMint', that was initially included inside 'howAboutToExecute' function, has been removed, simplifying the code execution flow.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vikiival vikiival merged commit 5686215 into main Dec 15, 2023
@vikiival vikiival deleted the quick-fixes-drop branch December 15, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants