-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drop modal bugs #8536
fix: drop modal bugs #8536
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request introduces a modal step change that includes addition of error handling during image preloading and refactors the DropConfirmModal.vue component to improve code clarity and manageability. This gets implemented by adding a 'ModalStep' type and computed properties for various steps of the modal. It also modifies the preloadImage function in dom.ts to add an event listener for 'error' event. Finally, logic is implemented to manage retries during image preloading and modal step changes. This results in a more structured approach to managing the modal steps and image loading process. |
asking again for subscription problem only truly happened when drop went live, lets see! minting process: mintagaindelete.mp4 |
yep let's see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall
some minor code style suggestions
|
Code Climate has analyzed commit 73b8963 and detected 0 issues on this pull request. View more on Code Climate. |
CleanShot.2023-12-14.at.13.59.30.mp4CleanShot.2023-12-14.at.14.24.42.mp4 |
@hassnian Is it good to go? |
almost done |
oh nevermind wrong pr I thought you meant the pr review that you requested :d , didn't check the pr title this is ready |
pay 20 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
PR Type
Context
Closes Seems after countdown of 2 minutes gone, empty art rendered #8483
add: Multiple retries when preloading nft cover
Closes Drop asked me to subscribe again #8485
ref: modal steps will not move back to email step if count goes to 0 seconds
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸
CleanShot.2023-12-12.at.09.28.45.mp4
Copilot Summary
🤖[deprecated] Generated by Copilot at ebb8a1a
Refactored the drop confirmation modal to use a more declarative approach with a
modalStep
ref and watch effects. Improved the error handling and performance of the NFT image preloading by using theerror
event and rejecting the promise inpreloadImage
.🤖[deprecated] Generated by Copilot at ebb8a1a