Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop modal bugs #8536

Merged
merged 8 commits into from
Dec 14, 2023
Merged

fix: drop modal bugs #8536

merged 8 commits into from
Dec 14, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Dec 12, 2023

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2023-12-12.at.09.28.45.mp4

Copilot Summary

🤖[deprecated] Generated by Copilot at ebb8a1a

Refactored the drop confirmation modal to use a more declarative approach with a modalStep ref and watch effects. Improved the error handling and performance of the NFT image preloading by using the error event and rejecting the promise in preloadImage.

🤖[deprecated] Generated by Copilot at ebb8a1a

To show off an NFT in a modal
We preload the image with a portal
But if there's an error
We don't want to terror
So we reject the promise as normal

@kodabot
Copy link
Collaborator

kodabot commented Dec 12, 2023

WARNING @hassnian PR for issue #8483 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8483

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 73b8963
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/657ac897a64a590008ef9e5a
😎 Deploy Preview https://deploy-preview-8536--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Dec 12, 2023

SUCCESS @hassnian PR for issue #8485 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Contributor

reviewpad bot commented Dec 12, 2023

AI-Generated Summary: This pull request introduces a modal step change that includes addition of error handling during image preloading and refactors the DropConfirmModal.vue component to improve code clarity and manageability. This gets implemented by adding a 'ModalStep' type and computed properties for various steps of the modal. It also modifies the preloadImage function in dom.ts to add an event listener for 'error' event. Finally, logic is implemented to manage retries during image preloading and modal step changes. This results in a more structured approach to managing the modal steps and image loading process.

@reviewpad reviewpad bot added the small Pull request is small label Dec 12, 2023
@hassnian hassnian marked this pull request as ready for review December 12, 2023 04:34
@hassnian hassnian requested a review from a team as a code owner December 12, 2023 04:34
@hassnian hassnian requested review from preschian and roiLeo and removed request for a team December 12, 2023 04:34
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 12, 2023
@prury prury requested a review from daiagi December 13, 2023 13:09
@prury
Copy link
Member

prury commented Dec 13, 2023

asking again for subscription problem only truly happened when drop went live, lets see!

minting process:

mintagaindelete.mp4

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Dec 13, 2023
@hassnian
Copy link
Contributor Author

hassnian commented Dec 13, 2023

asking again for subscription problem only truly happened when drop went live, lets see!

minting process:

mintagaindelete.mp4

yep let's see

Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall
some minor code style suggestions

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Dec 14, 2023

Code Climate has analyzed commit 73b8963 and detected 0 issues on this pull request.

View more on Code Climate.

@hassnian
Copy link
Contributor Author

CleanShot.2023-12-14.at.13.59.30.mp4
CleanShot.2023-12-14.at.14.24.42.mp4

@vikiival
Copy link
Member

@hassnian Is it good to go?

@hassnian
Copy link
Contributor Author

@hassnian Is it good to go?

almost done

@hassnian
Copy link
Contributor Author

hassnian commented Dec 14, 2023

@hassnian Is it good to go?

almost done

oh nevermind wrong pr I thought you meant the pr review that you requested :d , didn't check the pr title

this is ready

@vikiival vikiival added this pull request to the merge queue Dec 14, 2023
@vikiival
Copy link
Member

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Dec 14, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 7.49 USD/DOT ~ 2.67 $DOT
🧗 13QUj3pZyFNfYj4AM336hRdyLQbevj5H3sR4PKmLEXLdwZhh
🔗 0xf6b2dbc5eb2a19b345064543f172d0b555722b9be44b15af88054b9f282ef5ed

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

Merged via the queue into kodadot:main with commit 0120777 Dec 14, 2023
@yangwao yangwao added the paid pull-request has been paid label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop asked me to subscribe again Seems after countdown of 2 minutes gone, empty art rendered
7 participants