Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove footer on Drop page #8545

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Remove footer on Drop page #8545

merged 2 commits into from
Dec 13, 2023

Conversation

prury
Copy link
Member

@prury prury commented Dec 12, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Screenshot 📸

  • My fix has changed UI

image

Copilot Summary

🤖[deprecated] Generated by Copilot at d852dde

Added a definePageMeta function to pages/[prefix]/drops/index.vue to use the 'no-footer' layout. This improves the UI of the drops page by removing the unnecessary footer component.

🤖[deprecated] Generated by Copilot at d852dde

definePageMeta
No footer for drops layout
A fresh spring cleaning

@prury prury requested a review from a team as a code owner December 12, 2023 21:43
@prury prury requested review from daiagi and Jarsen136 and removed request for a team December 12, 2023 21:43
@kodabot
Copy link
Collaborator

kodabot commented Dec 12, 2023

SUCCESS @prury PR for issue #8542 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e62623f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65795e19b770800008ad5f21
😎 Deploy Preview https://deploy-preview-8545--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 12, 2023
Copy link

codeclimate bot commented Dec 12, 2023

Code Climate has analyzed commit d852dde and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

reviewpad bot commented Dec 12, 2023

AI-Generated Summary: This pull request involves changes to the pages/[prefix]/drops/index.vue file. The footer on the 'drops' page has been removed by adding a new definePageMeta block, which sets the layout to 'no-footer'. In total, four lines of code have been added.

@roiLeo roiLeo added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit 89b8d95 Dec 13, 2023
@roiLeo roiLeo deleted the feat/remove-footer-drops branch December 13, 2023 07:33
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove footer from drops list
4 participants