Update main from develop #330

RobertPincus · 2025-01-07T12:57:55Z

Merge accumulated changes on develop into main. Getting ready for pre-release.

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.4.3 to 4.5.0. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.4.3...v4.5.0) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…_actions/develop/JamesIves/github-pages-deploy-action-4.5.0 Bump JamesIves/github-pages-deploy-action from 4.4.3 to 4.5.0

Update develop with changes from documentation branch

Build instructions point to the Github Pages site.

Deprecating NCHOME, NFHOME

Consolidating build information

Skip self-hosted jobs in the fork repositories, use new container tags

Update YML files for simplicity and consistency with CI. Update Python version to 3.11

Single level source for LW no-scattering solver; spectral mapping as the sqrt of the product of the mappings in each adjacent layer

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…_actions/develop/actions/upload-artifact-4 Bump actions/upload-artifact from 3 to 4

Remove a workaround for PGI Fortran 19 and `present` status; interpolate level temperatures on device.

Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add CI jobs that run the tests on the GPU partition of Levante. The compiler version and flags are what we currently use to build ICON by default. For security reasons, the jobs are skipped for PRs from the forks.

This adds CI tests with the NAG compiler on Levante with compiler version and flags currently used to build ICON by default. Both DP and SP floating models are tested, as are default and accelerator kernels, but not all possible combinations. Accelerator kernels fail with a run-time error and are marked as experimental.

) Scripts fails when individual tests fail, small tolerance adjustments to tests pass, small correction to LW source calculation in accel kernels, revert change in 5ac4d0a: nvfortran fails to pass present status of args to lower-level procedures

Fix subroutine intent, mark corresponding CI as not-experimental

Enable manual runs of CI , don't run CI on push except for main, develop

CI now reports success if a) the code compiles but fails at runtime with `cce-gpu-openmp` in self-hosted CI, and b) fails with an internal compiler error for `ifx-gpu-openmp`. See the PR for more details.

Adds stand-alone unit tests for solvers alone (in tests/rte[sl]w_unit_tests.F90). Longwave solvers are tested for correctness in radiative equilibrium and for invariance to choices (vertical orientation, problem size...). Shortwave solvers are tested only for invariance.

Streamline and add flexibility to the build process.

Fix cce-gpu-openacc-SP

@sjsprecious

Fix GPU runtime error on NVIDIA A100 with nvhpc/24.3, thanks to @sjsprecious

Adds C and Fortran headers for the kernels in *-kernels/api subdirectories. Kernel headers are tested for consistency against Fortran front-end. Changes the makefiles a) to not build the documentation by defaults, and b) to group the building and running of tests, so that make libs makes, um, only the libraries. --------- Co-authored-by: Alexander Soklev <alex@makepath.com>

@peterukk

Adopt suggestions by @peterukk in #215. Makes expensive direct beam computations even when solar zenith angle is < 0, but masks those results out in layers where the direct beam does not reach. This will have practical impacts only in columns where the top of the column is in sunlight but the bottom not (or if users aren't removing columns entirely below the horizon).

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.4 to 4.6.6. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.6.4...v4.6.6) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…_actions/develop/JamesIves/github-pages-deploy-action-4.6.6 Bump JamesIves/github-pages-deploy-action from 4.6.4 to 4.6.6

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.6 to 4.6.8. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.6.6...v4.6.8) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…_actions/develop/JamesIves/github-pages-deploy-action-4.6.8 Bump JamesIves/github-pages-deploy-action from 4.6.6 to 4.6.8

@skosukhin

…mi-CI Based on problems with the Lumi software stack we will temporarily disable CI on that host. To be revisited after @skosukhin reports back from a hackathon the week of Nov 10.

Separate cloud optics kernels from the Fortran front-end implementation. Update `nvfortran` used in Levante CI to 24.07.

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.8 to 4.6.9. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.6.8...v4.6.9) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.9 to 4.7.1. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.6.9...v4.7.1) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.7.1 to 4.7.2. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.7.1...v4.7.2) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…_actions/develop/JamesIves/github-pages-deploy-action-4.7.2 Bump JamesIves/github-pages-deploy-action from 4.7.1 to 4.7.2

* Fix work-around with reasonable code. * The following is bad in any performance-sensitive codes: + Using arrays instead of scalars. + Assigning to the same array element more than once in a loop-nest. While the compiler can in principle fix this up, it's actually too hard to ask for that and in the case fixed here, seriously trips up the Intel Fortran compiler. * Replace unnecessary log operation. * Replace division by multiplication of inverse. * Replace array reference with scalar. * Replace division by multiplication with inverse. * Keep data in float format. * In some cases these conversions are carried out via memory such that reading data just written to memory back into a register stalls the FPU. * Fix mix in precisions. --------- Co-authored-by: Thomas Jahns <jahns@dkrz.de>

Move from Gnu Make to CMake/Ninja as the build system and update continuous integration. See the PR history for details. --------- Co-authored-by: Chiel van Heerwaarden <chielvanheerwaarden@gmail.com> Co-authored-by: Robert Pincus <Robert.Pincus@columbia.edu> Co-authored-by: Alexander Soklev <alex@makepath.com>

Improves file handling during the running of tests and examples. See PR (#319) for details.

Exclude ifx/accel jobs rather than setting them up and skipping them.

Adds CMake install target for the RTE and RRTMGP libraries. Other CMake refinements. See the PR for details.

tests/check_variants creates a new output file sharing two of the input file dimensions. CMake scripting creates separate SW and LW files.

Updates project version in CMakeLists.txt. Not the same as the Github release version number!

CMake: install data files during testing and installation.

RobertPincus · 2025-01-07T13:14:26Z

Supersedes #328 .

Updates main with changes accumulated on develop. We will release alpha candidates to refine packaging with conda while continuing to make changes to develop.

Main changes include the Fortran API, for which vertical direction is now specified as part of ty_optical_properties_arry (see #287); changing from Gnu Make to CMake; refinements to gas optics kernels (#315), separate cloud optics kernels to accommodate the Python front end.

dependabot bot and others added 30 commits November 28, 2023 20:18

Merge pull request #243 from earth-system-radiation/dependabot/github…

bf4180d

…_actions/develop/JamesIves/github-pages-deploy-action-4.5.0 Bump JamesIves/github-pages-deploy-action from 4.4.3 to 4.5.0

Documentation -> develop (#244)

8131adc

Update develop with changes from documentation branch

Update Readme

b9dbe26

Build instructions point to the Github Pages site.

Simplify build flags (#247)

90925e3

Deprecating NCHOME, NFHOME

Update Documentation (#248)

9821324

Consolidating build information

Update CI configuration (#249)

fee55ca

Skip self-hosted jobs in the fork repositories, use new container tags

Update environment*.yml files (#251)

a8acd3b

Update YML files for simplicity and consistency with CI. Update Python version to 3.11

Simplify LW source functions (#250)

c61f373

Single level source for LW no-scattering solver; spectral mapping as the sqrt of the product of the mappings in each adjacent layer

Merge pull request #252 from earth-system-radiation/dependabot/github…

93e1062

…_actions/develop/actions/upload-artifact-4 Bump actions/upload-artifact from 3 to 4

Temperature and source function refinements (#253)

5ac4d0a

Remove a workaround for PGI Fortran 19 and `present` status; interpolate level temperatures on device.

Run CI jobs on Levante via GitLab (#255)

44e4352

Add CI jobs that run the tests on the GPU partition of Levante. The compiler version and flags are what we currently use to build ICON by default. For security reasons, the jobs are skipped for PRs from the forks.

Fix intent in subroutine lw_transport_noscat_up (#261)

9dcc9ba

Fix subroutine intent, mark corresponding CI as not-experimental

Reduce use of CI (#264)

a0ed5bf

Enable manual runs of CI , don't run CI on push except for main, develop

Run CI jobs on Lumi via GitLab (#265)

ebb1b8c

Align success/failure of CI with expectations (#267)

6cda868

CI now reports success if a) the code compiles but fails at runtime with `cce-gpu-openmp` in self-hosted CI, and b) fails with an internal compiler error for `ifx-gpu-openmp`. See the PR for more details.

Fix cce-gpu-openacc-SP

3274155

Small refactoring for the build system (#266)

e242466

Streamline and add flexibility to the build process.

Merge pull request #268 from earth-system-radiation/fix-lumi-sp-ci

1ffd140

Fix cce-gpu-openacc-SP

Make front-end/kernel libraries by default

dc88744

fix the gpu runtime error on nvidia a100 with nvhpc/24.3

f6d4a63

Merge pull request #273 from sjsprecious/fix_gpu_error

1b75505

Fix GPU runtime error on NVIDIA A100 with nvhpc/24.3, thanks to @sjsprecious

Skip GitLab CI for dependabot (#278)

8cf510c

dependabot bot and others added 23 commits September 27, 2024 20:30

Merge pull request #296 from earth-system-radiation/dependabot/github…

fa63b2b

…_actions/develop/JamesIves/github-pages-deploy-action-4.6.6 Bump JamesIves/github-pages-deploy-action from 4.6.4 to 4.6.6

Merge pull request #297 from earth-system-radiation/dependabot/github…

fa125c0

…_actions/develop/JamesIves/github-pages-deploy-action-4.6.8 Bump JamesIves/github-pages-deploy-action from 4.6.6 to 4.6.8

Update CI to use current data release

a7cdefb

Disable Lumi CI (compilers are broken)

2d69752

Merge pull request #301 from earth-system-radiation/hotfix-disable-lu…

3f7919f

…mi-CI Based on problems with the Lumi software stack we will temporarily disable CI on that host. To be revisited after @skosukhin reports back from a hackathon the week of Nov 10.

Self-hosted CI no longer has access to resources

210e234

Separate cloud optics kernels (#302)

06ea828

Separate cloud optics kernels from the Fortran front-end implementation. Update `nvfortran` used in Levante CI to 24.07.

Merge pull request #308 from earth-system-radiation/dependabot/github…

c2a6e43

…_actions/develop/JamesIves/github-pages-deploy-action-4.7.2 Bump JamesIves/github-pages-deploy-action from 4.7.1 to 4.7.2

CMake: add missing test dependencies (#319)

4573539

Improves file handling during the running of tests and examples. See PR (#319) for details.

ci: exclude failing ifx accel test (#321)

986c539

Exclude ifx/accel jobs rather than setting them up and skipping them.

CMake: add install target (#323)

a7d6a69

Adds CMake install target for the RTE and RRTMGP libraries. Other CMake refinements. See the PR for details.

Tests don't write to inputs (#322)

7055137

tests/check_variants creates a new output file sharing two of the input file dimensions. CMake scripting creates separate SW and LW files.

cmake: install data files

ce66160

Project version in CMake to 1.9.0

6769f2b

Updates project version in CMakeLists.txt. Not the same as the Github release version number!

CMake installs data files

529522c

CMake: install data files during testing and installation.

Merge branch 'develop' into main

2c4a848

RobertPincus requested a review from skosukhin January 7, 2025 12:58

skosukhin approved these changes Jan 7, 2025

View reviewed changes

RobertPincus merged commit 2c4a848 into main Jan 7, 2025
41 checks passed

RobertPincus deleted the feature-update-main-from-develop branch January 7, 2025 13:16

This was referenced Jan 7, 2025

Update develop from main #329

Closed

CMake installation includes data files? #325

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update main from develop #330

Update main from develop #330

RobertPincus commented Jan 7, 2025

RobertPincus commented Jan 7, 2025

Update main from develop #330

Update main from develop #330

Conversation

RobertPincus commented Jan 7, 2025

RobertPincus commented Jan 7, 2025