Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of red crosses in the CI reports #267

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Conversation

skosukhin
Copy link
Collaborator

This should be the first PR in a long time without the annoying red crosses in the CI report.

Several jobs in our CI workflows are known to fail. Currently, we set continue-on-error: true for them. This makes at least the workflow status green. However, the red crosses pop up in the PR and commit CI reports. Getting used to them does not look like a good idea to me. One way of dealing with it is to simply remove the jobs. That would be fine with me but I accept the arguments for keeping them.

Job cce-gpu-openmp is known to fail at the runtime. This PR changes it so that it is marked green if it does fail at the runtime and is considered as failed otherwise. That is, the job fails the whole Self-hosted CI workflow if it does NOT fail against the expectations.

The ifx+accel jobs are known to fail at the build time due to internal compiler errors. This PR changes them so that they are marked green if they fail at the build time with the Internal compiler error substring in the build log. In all other cases, the jobs fail the whole Continuous integration in a box.

Copy link
Member

@RobertPincus RobertPincus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a "wow" emoji? I appreciate that the PR makes clear what our expectations are. Also we know the current self-hosted CI will go away when Daint is retired later this year.

@RobertPincus RobertPincus merged commit 6cda868 into develop Feb 19, 2024
34 checks passed
@RobertPincus RobertPincus deleted the ci-no-red-crosses branch February 19, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants