Simplify LW source functions #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexeedm I'm especially interested in any thoughts you have on the GPU implementation |
|
Long after the fact, here are comparisons of accuracy for present-day RFMIP atmospheres |
RobertPincus
added a commit
that referenced
this pull request
May 21, 2024
… API (#284) Accumulated changes and bug fixes. Changes LW answers (data repo is alsoupdated). - New LW weights and secants (Change LW quadrature angles #282) - A single source function on levels (Simplify LW source functions #250) - Kernel API header files in Fortran and C (Add kernel API #272) - Refactored two-stream, fixing RTE shortwave kernel not vectorizing #215 (Re-vectorize SW two-stream #275) - Buxfixes, change to internal build systems and continuous integration (thanks to @skosukhin for ongoing help)
sriharshakandala
added a commit
to CliMA/RRTMGP.jl
that referenced
this pull request
Jun 14, 2024
1 task
sriharshakandala
added a commit
to CliMA/RRTMGP.jl
that referenced
this pull request
Jun 14, 2024
sriharshakandala
added a commit
to CliMA/RRTMGP.jl
that referenced
this pull request
Jun 14, 2024
sriharshakandala
added a commit
to CliMA/RRTMGP.jl
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original formulation of RRTMGP uses separate spectral maps for upwelling and downwelling radiation at each level. Here they are combined as sqrt(map1 * map2). This reduces memory traffic between gas optics and solver by about 25% and makes the solvers more generic.
Differences introduced to the test cases are of order 0.06 W/m2. This exceeds the threshold we've been using to check for equivalence (7e-4). In this iteration the threshold has been relaxed to allow the tests to pass - is this the right approach, or would it be better to establish new test data?