Thomas Jahn's gas optics interpolation fixes #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The following is bad in any performance-sensitive codes: + Using arrays instead of scalars. + Assigning to the same array element more than once in a loop-nest. While the compiler can in principle fix this up, it's actually too hard to ask for that and in the case fixed here, seriously trips up the Intel Fortran compiler.
* In some cases these conversions are carried out via memory such that reading data just written to memory back into a register stalls the FPU.
Refine gas optics interpolation
This was referenced Jan 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition on top of #312 that adjusts tolerances in
tests/test_equivalenceto allownvfortranto pass the CI with double precision.