Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring for the build system #266

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Conversation

skosukhin
Copy link
Collaborator

@skosukhin skosukhin commented Feb 16, 2024

  • fixes the parallel building in the tests directory;
  • switches to the recommended way of calling make recursively;
  • gives the users control over the maximum number of make processes (generally, -j without a value gives worse performance than with the value set to the number of virtual cores on a machine; it's also not very nice towards other users to spawn the unlimited number of processes on a login node);
  • makes the check recipes honour the PYTHON environment variable when locating the Python interpreter (the python executable is not generally available and the users might want to set it either to python3 or to the path to the executable in a virtual environment).

Depends on #265

@RobertPincus
Copy link
Member

I merged #265. Let me know when this PR is ready, @skosukhin

@skosukhin skosukhin marked this pull request as ready for review February 19, 2024 09:28
@skosukhin
Copy link
Collaborator Author

@RobertPincus this is ready.

Copy link
Member

@RobertPincus RobertPincus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up!

@RobertPincus RobertPincus merged commit e242466 into develop Feb 19, 2024
34 checks passed
@RobertPincus RobertPincus deleted the refactor-building branch February 19, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants