Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Container Insights getting start page, Prometheus and ECS Prometheus #128

Merged
merged 12 commits into from
Jul 8, 2021
Merged

Add Container Insights getting start page, Prometheus and ECS Prometheus #128

merged 12 commits into from
Jul 8, 2021

Conversation

pingleig
Copy link
Contributor

@pingleig pingleig commented Jun 24, 2021 •
edited
Loading

Preview https://trusting-lewin-3415ee.netlify.app/docs/getting-started/container-insights

This PR is related to #103 and #118 as they need to move the files under container-insights folder and link to sub pages in the landing page /container-insights

  • Add /container-insights as index for all CloudWatch Container Insights related guides
  • Add /container-insights/prometheus for Container Insights Prometheus, common part of EKS and ECS merged into the first index page.
  • Add /container-insights/ecs-prometheus for ECS Prometheus

@pingleig
Copy link
Contributor Author

cc @pxaws @JohnWu20 @bjrara please check the pages for container insights and container insights prometheus. We might need another page as index/common page for container insights container metrics on EKS and EC2 instance.

This was referenced Jun 24, 2021
Merged
Closed
@pingleig pingleig changed the title Add container insights getting start page, Prometheus and ECS Prometheus Add Container Insights getting start page, Prometheus and ECS Prometheus Jun 24, 2021
@pingleig pingleig mentioned this pull request Jun 30, 2021
Merged
mxiamxia
mxiamxia approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

alolita
alolita reviewed Jul 8, 2021
View reviewed changes
Copy link
Contributor

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct all usage of the following:

  • AWS OTel Collector to ADOT Collector
  • Container Insight Prometheus - this cannot be used - trademark violation ; you can use Container Insights support for Prometheus metric types
  • collector to Collector

alolita
alolita suggested changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct all usage of the following:

  • AWS OTel Collector to ADOT Collector
  • Container Insight Prometheus - this cannot be used - trademark violation ; you can use Container Insights support for Prometheus metric types
  • collector to Collector

@alolita alolita merged commit 1f756e8 into aws-otel:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxaws pxaws pxaws left review comments

@mxiamxia mxiamxia mxiamxia approved these changes

@alolita alolita alolita approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pingleig @alolita @mxiamxia @pxaws