Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc for cloudwatch container insights #103

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

pxaws
Copy link
Contributor

@pxaws pxaws commented Apr 21, 2021

Add public doc for supporting CloudWatch Container Insights in EKS. This doc is a part of the next release for AWS OpenTelemetry Collector.

@pxaws pxaws force-pushed the doc-for-container-insights branch from dfd00c3 to cff2b73 Compare April 22, 2021 20:54
Copy link
Contributor

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold until PRs are merged in OTEL.

@pxaws pxaws force-pushed the doc-for-container-insights branch from 8e8a5ae to 84e92cb Compare June 25, 2021 00:30
@pingleig
Copy link
Contributor

pingleig commented Jul 7, 2021

Preview https://trusting-lewin-3415ee.netlify.app/docs/getting-started/container-insights/eks-infra

Copy link
Contributor

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct all usage of:

  • Container Insight Prometheus - trademark violation. please fix - see comments on related PR
  • AWS OTel Collector to ADOT Collector
  • collector to Collector

@pxaws pxaws force-pushed the doc-for-container-insights branch from 96835c6 to 14ca800 Compare July 8, 2021 16:16
@pxaws
Copy link
Contributor Author

pxaws commented Jul 8, 2021

Please correct all usage of:

  • Container Insight Prometheus - trademark violation. please fix - see comments on related PR
  • AWS OTel Collector to ADOT Collector
  • collector to Collector

They are addressed in the latest commit.

@alolita alolita merged commit 9e627e0 into aws-otel:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants