Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs: Add internal doc and cfn template for ECS Prometheus #560

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

pingleig
Copy link
Member

@pingleig pingleig commented Jun 24, 2021

Description:

Only apply to Container Insights ECS Prometheus

  • Add cfn template
  • Add doc for some tricky parts and future work

btw: user doc will be another PR aws-otel/aws-otel.github.io#128 https://github.com/aws-otel/aws-otel.github.io draft is in https://github.com/pingleig/aws-otel.github.io/tree/ecssd-draft/src/docs/getting-started/container-insights

Link to tracking Issue:

Testing:

N/A

Documentation:

This is a doc PR

Only apply to Container Insights Prometheus
@pingleig pingleig added the documentation Improvements or additions to documentation label Jun 24, 2021
@pingleig pingleig requested a review from mxiamxia June 24, 2021 04:23
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #560 (9fd148e) into main (3910907) will increase coverage by 1.55%.
The diff coverage is n/a.

❗ Current head 9fd148e differs from pull request most recent head d94bed9. Consider uploading reports for the commit d94bed9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   61.82%   63.38%   +1.55%     
==========================================
  Files           8        8              
  Lines         186      213      +27     
==========================================
+ Hits          115      135      +20     
- Misses         55       62       +7     
  Partials       16       16              
Impacted Files Coverage Δ
tools/version/build.go 100.00% <0.00%> (ø)
pkg/config/config_factory.go 100.00% <0.00%> (ø)
pkg/extraconfig/container.go 0.00% <0.00%> (ø)
pkg/userutils/set_uid_gid.go 0.00% <0.00%> (ø)
pkg/defaultcomponents/defaults.go 80.39% <0.00%> (+1.22%) ⬆️
pkg/extraconfig/extraconfig.go 88.57% <0.00%> (+1.47%) ⬆️
pkg/userutils/userutil_linux.go 26.08% <0.00%> (+1.89%) ⬆️
pkg/logger/logger.go 80.55% <0.00%> (+3.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3910907...d94bed9. Read the comment docs.

- Use ECR image in yaml template
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mxiamxia mxiamxia merged commit 49c592a into aws-observability:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants