Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Init doc for container insight ECS prometheus #435

Closed
wants to merge 6 commits into from

Conversation

pingleig
Copy link
Member

@pingleig pingleig commented Apr 12, 2021

Description: <Describe what has changed.

Preview ecs-prometheus

Link to tracking Issue:

#412

Testing: < Describe what testing was performed and which tests were added.>

Documentation: < Describe the documentation added.>

@pingleig pingleig added this to the ADOT Collector v0.9.0 milestone Apr 12, 2021
Copy link
Contributor

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pingleig these docs should be added to the developer docs on the ADOT site at aws-otel.github.io

cc: @awssandra @ntyrewalla

@codecov-io
Copy link

Codecov Report

Merging #435 (8becf31) into main (8c7ce3d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   81.89%   81.89%           
=======================================
  Files           6        6           
  Lines         116      116           
=======================================
  Hits           95       95           
  Misses         11       11           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c7ce3d...8becf31. Read the comment docs.

pingleig added 6 commits June 21, 2021 14:19
- creates iam role
- creates ssm
- it's working, but the paramateres of cfn need to be tweaked
By default its security group does NOT allow ingress within the VPC, so
it has to be updated manually for prometheus scrpaer to work.
@codecov-commenter
Copy link

Codecov Report

Merging #435 (d17fcce) into main (0134db7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   61.45%   61.45%           
=======================================
  Files           8        8           
  Lines         179      179           
=======================================
  Hits          110      110           
  Misses         54       54           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0134db7...d17fcce. Read the comment docs.

@pingleig
Copy link
Member Author

Closed for #560 and aws-otel/aws-otel.github.io#128

@pingleig pingleig closed this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants