Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutor for ECS EC2 instance metrics #118

Merged
merged 7 commits into from
May 26, 2021

Conversation

JohnWu20
Copy link
Contributor

Add tutor for ECS EC2 instance metrics

--region ${Region}
```
3. Go to you ECS Console and see if the task is running.
4. Go to the <Link to="/docs/setup/results-EC2-instance-metrics">Results</Link> section to learn how to check the collected metrics and traces.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Go to the <Link to="/docs/setup/results-EC2-instance-metrics">Results</Link> section to learn how to check the collected metrics and traces.
4. Go to the <Link to="/docs/setup/results-EC2-instance-metrics">Results</Link> section to learn how to check the collected metrics.

src/docs/setup/ecs/cfn-for-ecs-ec2-instance.mdx Outdated Show resolved Hide resolved
JohnWu20 and others added 4 commits May 21, 2021 14:30
Co-authored-by: Rayhan Hossain (Mukla.C)  <hossain.rayhan@outlook.com>
Co-authored-by: Rayhan Hossain (Mukla.C)  <hossain.rayhan@outlook.com>
Co-authored-by: Rayhan Hossain (Mukla.C)  <hossain.rayhan@outlook.com>
Co-authored-by: Rayhan Hossain (Mukla.C)  <hossain.rayhan@outlook.com>
@@ -27,7 +28,7 @@ If you don't have a cluster, follow this <Link to="/docs/setup/ecs/create-cluste

<SectionSeparator />

## 2. Setup the AWS OTel Collector
## 2. Setup the AWS OTel Collector for Xray, StatsD and ECS Container metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 2. Setup the AWS OTel Collector for Xray, StatsD and ECS Container metrics
## 2. Setup the AWS OTel Collector for Xray, StatsD and ECS Container metrics with CloudWatch

src/docs/setup/ecs.mdx Outdated Show resolved Hide resolved
Otel to OTel
Copy link
Contributor

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made editorial changes. Will merge for release.

@hossain-rayhan
Copy link
Contributor

hossain-rayhan commented May 26, 2021

This change should be included in June release. The code has a dependency and not merged yet I believe. @JohnWu20 please confirm.

Co-authored-by: Min Xia <mxiamxia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants