Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Enable Container Insight ECS Prometheus #570

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

pingleig
Copy link
Member

@pingleig pingleig commented Jun 30, 2021

Description:

From

Link to tracking Issue:

Testing:

 python3 e2etest/get-testcases.py ecs_matrix                                                                                                                                               

{"testcase": ["xrayreceiver", "statsd", "statsd_mock", "otlp_metric", "otlp_trace", "ecsmetrics", "otlp_grpc_exporter_metric_mock", "otlp_grpc_exporter_trace_mock", "otlp_http_exporter_metric_mock", "otlp_http_exporter_trace_mock", "sapm_exporter_trace_mock", "signalfx_exporter_metric_mock", "dynatrace_exporter_metric_mock", "datadog_exporter_metric_mock", "datadog_exporter_trace_mock", "newrelic_exporter_trace_mock", "newrelic_exporter_metric_mock", "prometheus_mock", "prometheus_static", "zipkin_mock", "jaeger_mock", "logzio_exporter_trace_mock", "containerinsight_ecs_prometheus"], "launch_type": ["EC2", "FARGATE"]}

Only tested when launching collector on fargate, but it should work when launching collector on EC2 as long as it's same VPC and security group has right setting.

Documentation:

@pingleig pingleig requested a review from mxiamxia June 30, 2021 22:58
@codecov-commenter
Copy link

Codecov Report

Merging #570 (d6e3242) into main (3687963) will not change coverage.
The diff coverage is n/a.

❗ Current head d6e3242 differs from pull request most recent head 0fbd046. Consider uploading reports for the commit 0fbd046 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #570   +/-   ##
=======================================
  Coverage   61.82%   61.82%           
=======================================
  Files           8        8           
  Lines         186      186           
=======================================
  Hits          115      115           
  Misses         55       55           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3687963...0fbd046. Read the comment docs.

@mxiamxia mxiamxia merged commit 5ece4e2 into aws-observability:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants