[ecs][prometheus] Add ContainerInsight ECS Prometheus #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Run extra apps as service, i.e., no longer run collector as sidecar - Add templates for extra sample apps - NOT tested, jusrt porting previous unmerged PRs
For cloudwatch container insights
Should use taskDefinitionFamily directly, copied namespace from eks ...
mxiamxia
reviewed
Jun 18, 2021
Comment on lines
+78
to
+83
| if (cwContext.getNginx() != null) { | ||
| apps.add(cwContext.getNginx()); | ||
| } | ||
| if (cwContext.getJmx() != null) { | ||
| apps.add(cwContext.getJmx()); | ||
| } |
There was a problem hiding this comment.
do we only verify 2 kind of workloads?
There was a problem hiding this comment.
We can't verify nginx plus unless we change a email every 30 days to get a trail. The app mesh environment is too hard to setup using terraform and is not that useful because as long as one workload is running, it should works for other, the discovery and scraping mechanism is the same.
mxiamxia
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform
VPC
ECS
Prometheus
Tested using my own account, for github action, we need to update security group.