Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Release 1.10 #399

Closed
esteve opened this issue Nov 2, 2018 · 40 comments
Closed

Release 1.10 #399

esteve opened this issue Nov 2, 2018 · 40 comments

Comments

@esteve
Copy link
Contributor

esteve commented Nov 2, 2018

Announcement

  • Autoware is now protected under Apache License Version 2.0 (#1707)
  • ROS Indigo is no longer supported as announced at Ver.1.9.0 (#1743)
  • The following commands are required once when you build from source (#1689)
cd Autoware/ros
rosdep update
rosdep install --from-paths src --ignore-src --rosdistro $ROS_DISTRO

New Features

Improvements

  • Added functionality to run.sh in docker/generic (#1617)
  • Tracking accuracy can be measured by KITTI data (#1671)
  • Crossbuild support of multiple gmsl cameras (#1683)
  • Added /sim_lidar tf frame to wf_simulator (#1710)
  • ymc actuation package uses vehicle_cmd instead of twist_cmd for woriking with twist_gate (#1649)

Bug Fixes

  • Disable forced termination when ndt_matching can not write log data (#1824)
  • Fixed a bug where the speed is handled as positive when the gear is reverse (#1740)
  • Fixed a bug where intrinsic calibration cannot detect OpenCV version (#1696)
  • Fixed a bug where ros-kinetic-grid-map-visualization is not installed (#1780)
  • Fixed Milee urdf (#1687)
  • Fixed a bug where pcd_filter fails when point cloud has large values (#1730)

Known Bugs

  • Unable to launch Runtime Manager with colcon build (#1865)

For Developers

  • GitLab CI executes build and some tests, and should succeed at pull request (#1563, Replace CI links to GitLab autoware#1777)
  • Travis CI executes industrial_ci and should succeed at pull request (#1832)
  • Added code coverage report (#1654)
@esteve
Copy link
Contributor Author

esteve commented Nov 2, 2018

@kfunaoka I've created this ticket so that we can have a list of the planned changes for the 1.10 release and decide what should go in and what should be postponed as suggested by @shinpei0208 https://autoware-developer.slack.com/archives/C3C8XRV99/p1541114851079100

@kfunaoka
Copy link

kfunaoka commented Nov 6, 2018

I'd like to also entry https://github.com/CPFL/Autoware/issues/1551 and https://github.com/CPFL/Autoware/issues/1693 once I can make them meaningful :)

@kfunaoka
Copy link

kfunaoka commented Nov 7, 2018

New entry: autowarefoundation/autoware#1594

@kfunaoka
Copy link

kfunaoka commented Nov 7, 2018

New entry: autowarefoundation/autoware#1645

@kfunaoka
Copy link

kfunaoka commented Nov 7, 2018

@kfunaoka
Copy link

kfunaoka commented Nov 8, 2018

@esteve
Copy link
Contributor Author

esteve commented Nov 9, 2018

@kfunaoka I've added the tickets to the description

@hakuturu583
Copy link

Sorry for my late.
New entry autowarefoundation/autoware#1795

@esteve
Copy link
Contributor Author

esteve commented Dec 20, 2018

@hakuturu583 thanks for letting us know, but unfortunately it's too late for this release to include autowarefoundation/autoware#1795. The goal of this ticket is to list all the features and improvements that will go into a release before starting the release, not after. This helps us have a vision of what the priorities are for a given release/milestone and how efforts should be directed.

In any case, it looks like autowarefoundation/autoware#1795 is a good candidate for Autoware 1.11, we'll add it to the next release.

@kfunaoka
Copy link

Open source community should have a certain amount of discipline to work with a lot of people. I added a procedure into Contribution Rules to declare which version each issue is targeting.
https://github.com/CPFL/Autoware/wiki/Contribution-Rules#development-workflow

@hakuturu583 Sorry for the insufficient announcement. Also I'd like to encourage you to improve Autoware more and more. For that, let's talk what you are working on within the community :)

@esteve I've also talked with @hakuturu583. Though we can postpone autowarefoundation/autoware#1795, simulator is a very good tool for autonomous driving, and it's worth for Autoware and users. Since autowarefoundation/autoware#1795 does not affect the essential part of Autoware, we might be able to decide on importing autowarefoundation/autoware#1795 to test Autoware functions by challengers. How do you think in this case?

@hakuturu583 Any other comments?

@kfunaoka
Copy link

Sorry, I have to withdraw autowarefoundation/autoware#1693 and #324.

@esteve
Copy link
Contributor Author

esteve commented Jan 2, 2019

@kfunaoka It was mostly because I think that we should be stating what we're going to work on for the current cycle, so we can anticipate and properly test everything before making a new release. That doesn't mean we can't squeeze in a new feature in the middle of the cycle, but they should have a rationale and give enough time to test it.

Unfortunately this wasn't the case with autowarefoundation/autoware#1795, it broke the build, doesn't have any tests at all and was merged in a rush.

autowarefoundation/autoware#1795 is a very valuable contribution and I'd really like it getting merged, but it'd be good to be a bit more disciplined with releases and plan a bit better, it'd help users anticipate any potentially incompatible changes before a release, for example.

@hakuturu583
Copy link

@esteve autowarefoundation/autoware#1795 have already merged to develop, and travis CI said that the develop branch was not broken.
Please show me the CI log.

@esteve
Copy link
Contributor Author

esteve commented Jan 3, 2019

@hakuturu583 we no longer use Travis for CI, and these are the tickets that report that the simulator bridge broke the build:

https://github.com/CPFL/Autoware/issues/1802
https://github.com/CPFL/Autoware/issues/1807

@hakuturu583
Copy link

@esteve OK, I am fixing now.

@esteve
Copy link
Contributor Author

esteve commented Jan 3, 2019

@hakuturu583 no worries, it's really not big of a deal :-) I think the work you did in autowarefoundation/autoware#1795 is really valuable, but let's plan releases in advance so we can have more time to test them more thoroughly.

@kfunaoka
Copy link

kfunaoka commented Jan 5, 2019

@hakuturu583 @esteve That'll make the process more workable :) I'd like to request not only contributers but reviewers to check the release plan of each pull request. I'll create the check list that reviewers reference.

Regarding this release 1.10, I'd like to provide autonomous driving to who has no real cars if it is not critical. Were the problems fixed or not? I found autowarefoundation/autoware#1808 was merged.

Finally, I apologize to @zelenkovsky and @hakuturu583. I knew they were working for the release 1.10. But I forgot to request to declare on the issue.
https://github.com/CPFL/Autoware/issues/1724#issuecomment-441248170

@kfunaoka
Copy link

kfunaoka commented Jan 7, 2019

@sgermanserrano @esteve Would you list pull requests that are better to be merged into v1.10? My understanding is:

@sgermanserrano
Copy link

@kfunaoka @aohsato @cirpue49 as discussed in Slack #motion-planning channel A* is better used with costmap_generator than with points2costmap (which seems older -> can be deprecated and substituted by costmap_generator?).
I'd suggest pushing [Feature] Improve Hybrid A* planner autowarefoundation/autoware#1594 from v1.10 to v1.11 to:

@kfunaoka
Copy link

kfunaoka commented Jan 7, 2019

@sgermanserrano I heard the discussion from @aohsato. Let's postpone to 1.11!

@esteve
Copy link
Contributor Author

esteve commented Jan 7, 2019

@kfunaoka I postponed autowarefoundation/autoware#1704 because I thought it'd make it for the original 1.10 cutoff, but since it was delayed, I think we can try. I'll keep testing it locally, I'd appreciate your (and @sgermanserrano 's) feedback, since it will have a direct impact on the users.

autowarefoundation/autoware#1741 should be mergeable, but I need another +1.

@kfunaoka
Copy link

kfunaoka commented Jan 7, 2019

I've updated the status.

@esteve
Copy link
Contributor Author

esteve commented Jan 7, 2019

@kfunaoka I've added autowarefoundation/autoware#1704 to the list of tickets for this release and merged the PR.

@esteve
Copy link
Contributor Author

esteve commented Jan 7, 2019

Once autowarefoundation/autoware#1741 passes, I'll merge it as well.

@sgermanserrano
Copy link

@isamu-takagi @messi49 do #375 and #408 have associated PRs? or are they features on a planning/developing stage?

@isamu-takagi
Copy link
Contributor

@sgermanserrano
Sorry, Autoware Launcher is under development. I'll release it in v1.11.

@kfunaoka
Copy link

kfunaoka commented Jan 8, 2019

@amc-nu @sgermanserrano @esteve How about creating release branch for v1.10 from HEAD of develop, merging autowarefoundation/autoware#1837 into the release branch, and staring test on the release branch?

@kfunaoka
Copy link

kfunaoka commented Jan 8, 2019

@amc-nu
Copy link
Member

amc-nu commented Jan 8, 2019

Hello @esteve @sgermanserrano and @kfunaoka

Please don't include autowarefoundation/autoware#1704 as it is in 1.10
I found the following problems:

  1. run script won't work, as it is.
    Please refer to https://github.com/CPFL/Autoware/blob/develop/ros/run#L52
  2. Even after updating the script to install space. Since currently most of the packages do not include the install command for launch, and companion files. Only manual ros run commands will work, which are mostly not used by the UI and the current documentation.
    https://github.com/CPFL/Autoware/blob/develop/ros/src/util/packages/runtime_manager/scripts/computing.yaml
  3. Compiling with catkin_make workflow is also broken, so it cannot be used as an alternative.

Fixing the above points will require a considerable amount of work. For this reason, I consider appropriate

  1. First to apply Remove obsolete packages and nodes #389 , then
  2. Fix the file installation commands in the CMakeFiles and
  3. Finally include Use colcon as the build tool autoware#1704 + fixes in a release.

Otherwise, current users (ourselves included) will face a lot of problems. Please let me know your thoughts on this.

@esteve
Copy link
Contributor Author

esteve commented Jan 8, 2019

@amc-nu I've reverted autowarefoundation/autoware#1704 in autowarefoundation/autoware#1838, please have a look at it. However, the real problem is that for a long time the Autoware run script assumed that it was using the devel space, which is not a correct workflow in ROS. colcon is stricter about that, there's no devel space at all, only build and install, so if the packages are not properly written and they don't have an install target, they can't be used.

What I find strange is that catkin fails for you. Doesn't catkin_make_release work for you?

@kfunaoka
Copy link

kfunaoka commented Jan 8, 2019

It seems all issues and problems are solved by some directions.
I've created the release/1.10.0 branched from f77b784.
Let me know if something should be done additionally.

Since we changed the build tool from catkin to calcon,
we might need test time a little longer than usual.
How about these target plan?

Version Merged Release
v1.10 Jan. 8th, 2018 (today) Jan. 17th, 2018

Also I'm thinking the docker image for test such as autoware/autoware:1.10.0-kinetic-rc1 will be useful.

@esteve
Copy link
Contributor Author

esteve commented Jan 8, 2019

@kfunaoka looks good to me.

@kfunaoka
Copy link

kfunaoka commented Jan 9, 2019

I found the error #490. I'll check.

@kfunaoka
Copy link

I've uploaded autoware/autoware:1.10.0-kinetic-rc1 based on b21b663 into dockerhub.

@kfunaoka
Copy link

@esteve @sgermanserrano @amc-nu
I've created the release note at the headline of this issue.
Let me know if something should be added or modified.
I'll release tomorrow.

@kfunaoka
Copy link

@sgermanserrano Where can I look the latest code coverage report (#1654)?

@sgermanserrano
Copy link

@kfunaoka https://cpfl.gitlab.io/Autoware/

@kfunaoka
Copy link

Thanks!

I've updated the wiki page for the new docker scripts.
https://github.com/CPFL/Autoware/wiki/Generic-x86-Docker

@bdholt1
Copy link

bdholt1 commented Jan 23, 2019

Congrats on the release! Can this issue be closed now?

@kfunaoka
Copy link

Thank you for reminding!

@mitsudome-r mitsudome-r transferred this issue from autowarefoundation/autoware Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants