Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] CMake error & warning fixes on develop #1808

Merged
merged 3 commits into from
Jan 4, 2019
Merged

[fix] CMake error & warning fixes on develop #1808

merged 3 commits into from
Jan 4, 2019

Conversation

amc-nu
Copy link
Member

@amc-nu amc-nu commented Dec 24, 2018

Status

PRODUCTION / DEVELOPMENT

Description

Fixes autowarefoundation/autoware_ai#472 autowarefoundation/autoware_ai#468

Related PRs

#1790 #1683

Tested using industrial_ci

@esteve
Copy link
Contributor

esteve commented Jan 2, 2019

@amc-nu I added the following in the feature/use_colcon branch to ensure that the autoware_driveworks_gmsl_interface package is a proper catkin package.

esteve@ca123aa

Basically, just adding a call to the catkin_package macro is enough.

@hakuturu583
Copy link

LGTM

@amc-nu
Copy link
Member Author

amc-nu commented Jan 3, 2019

@esteve pushed the changes as we discussed, can you please review again,? and approve if you agree?
Thanks

@esteve
Copy link
Contributor

esteve commented Jan 3, 2019

@amc-nu looks great, thanks for fixing the issue and iterating on it.

@esteve
Copy link
Contributor

esteve commented Jan 3, 2019

@amc-nu one small change I just noticed, you now need to declare autoware_build_flags as a buildtool dependency in package.xml:

<buildtool_depend>autoware_build_flags</buildtool_depend>

@esteve
Copy link
Contributor

esteve commented Jan 3, 2019

@amc-nu I just saw that the dependency for autoware_build_flags wasn't introduced in this PR, but could you add it anyway? Thanks!

@amc-nu
Copy link
Member Author

amc-nu commented Jan 3, 2019

@esteve updated!

Thanks for noticing that!

Waiting for CI before merging

@esteve
Copy link
Contributor

esteve commented Jan 3, 2019

CI passed, yay! However, the current GitLab runner does not trigger the install target yet, so can't know for sure if the bug is fixed (though, I'm pretty sure it is).

https://gitlab.com/CPFL/Autoware/pipelines/42030601

@amc-nu I'm ok merging this PR, but I'll leave it up to you in case you want to make some more changes.

@amc-nu amc-nu merged commit e7309e4 into develop Jan 4, 2019
@amc-nu amc-nu deleted the fix/cmake_errors branch January 4, 2019 01:24
@amc-nu
Copy link
Member Author

amc-nu commented Jan 4, 2019

@esteve Thanks for all your help.
Confirmed with industrial_ci.

@kfunaoka kfunaoka mentioned this pull request Jan 5, 2019
Closed
@hakuturu583 hakuturu583 mentioned this pull request Jan 10, 2019
Closed
anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@amc-nu
[fix] CMake error & warning fixes on develop (autowarefoundation#1808)
7139b2f 
* CMake fixes

* CMake updated to remove unnecessary dependencies when the package is not built

* added autoware flags
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esteve esteve esteve approved these changes

@hakuturu583 hakuturu583 Awaiting requested review from hakuturu583

@kfunaoka kfunaoka Awaiting requested review from kfunaoka

Assignees
No one assigned
Labels
version:autoware-ai Autoware.AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amc-nu @esteve @hakuturu583 @mitsudome-r