Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use colcon as the build tool" #1838

Closed
wants to merge 1 commit into from
Closed

Revert "Use colcon as the build tool" #1838

wants to merge 1 commit into from

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jan 8, 2019

Reverts #1704

@esteve esteve force-pushed the revert-1704-feature/use_colcon branch from 9a69471 to 06c6e20 Compare January 8, 2019 08:02
@esteve esteve mentioned this pull request Mar 14, 2023
Closed
@amc-nu amc-nu mentioned this pull request Jan 8, 2019
Merged
kfunaoka
kfunaoka previously approved these changes Jan 8, 2019
View reviewed changes
Copy link

@kfunaoka kfunaoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Reverted with importing #1832.

@kfunaoka kfunaoka dismissed their stale review January 8, 2019 11:34

@amc-nu confirmed that colcon works fine at #1837 (comment). It seems this pull request can be closed without merging.

@esteve esteve closed this Jan 8, 2019
@esteve
Copy link
Contributor Author

esteve commented Jan 8, 2019

Thanks @amc-nu again for finding and fixing the bugs that were introduced in #1704

@esteve esteve deleted the revert-1704-feature/use_colcon branch January 8, 2019 11:37
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfunaoka kfunaoka kfunaoka left review comments

@amc-nu amc-nu Awaiting requested review from amc-nu

@sgermanserrano sgermanserrano Awaiting requested review from sgermanserrano

Assignees
No one assigned
Labels
version:autoware-ai Autoware.AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esteve @kfunaoka @mitsudome-r