Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dead github workflows | spell-check-differential #4279

Open
3 tasks done
HansRobo opened this issue Jul 14, 2023 · 31 comments
Open
3 tasks done

fix: dead github workflows | spell-check-differential #4279

HansRobo opened this issue Jul 14, 2023 · 31 comments
Assignees
@HansRobo @kminoda
Labels
status:help-wanted Assistance or contributors needed. status:stale Inactive or outdated issues. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)

Comments

@HansRobo
Copy link
Member

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Currently, spell-check-differential is one of the CI executed by pull requests as a trigger.
However, since there are too many cspell errors, the error is almost ignored when pull-request is merged.

So, it is desirable to reduce typos and revive spell-check-differential workflow!
if we archieve zero cspell errors, we have the option to set the CI to "required".

Purpose

To revive the dead spell-check-differential workflow

Possible approaches

We can...

  • fix the typos
  • add the words to dictionary
  • add ignore comment inline

We can track the number of entire cspell errors by spell-check-all workflow

Definition of done

Pass the spell-check-all workflow
@HansRobo HansRobo added the status:help-wanted Assistance or contributors needed. label Jul 14, 2023
@HansRobo HansRobo added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jul 14, 2023
@HansRobo
Copy link
Member Author

HansRobo commented Jul 18, 2023 •
edited
Loading

Errors: 786
#4280

@HansRobo
Copy link
Member Author

Errors: 730
main@2023/07/18 1:55P.M. JST

@HansRobo
Copy link
Member Author

We introduced spell-check-partial workflow to make spell-check "required" step by step.
#4320

@HansRobo
Copy link
Member Author

HansRobo commented Jul 19, 2023 •
edited
Loading

@kminoda is trying to test the spell-check-partial is works fine!

#4321
#4329
#4331

and he is preparing for actual operation of spell-check-partial!
#4327

@HansRobo
Copy link
Member Author

Errors: 668
main@2023/07/19 11:31 A.M.

This pull request works great for the reduction of errors this time!
#4281

@kminoda
Copy link
Contributor

kminoda commented Jul 19, 2023

Memo
spell-check-partial has been made required

@HansRobo
Copy link
Member Author

HansRobo commented Jul 19, 2023 •
edited
Loading

Errors: 667
main@2023/07/19 22:22 JST

#4332

@HansRobo
Copy link
Member Author

Errors: 695
main@2023/07/22 1:30 JST

@HansRobo
Copy link
Member Author

Errors: 689
main@2023/07/22 10:25 JST

@HansRobo
Copy link
Member Author

Errors: 680
main@2023/0724 14:39 JST

@HansRobo
Copy link
Member Author

spell-check-partial is enabled for localization!
#4377

@HansRobo
Copy link
Member Author

spell-check-partial is enabled for docs, simulator, tools, and vehicle!!
#4327

@HansRobo
Copy link
Member Author

Errors: 526
main@2023/0726 14:42 JST

#4289

@HansRobo
Copy link
Member Author

Errors: 517
main@2023/07/27 11:15 JST

@HansRobo
Copy link
Member Author

spell-check-partial is enabled for common
#4397

@HansRobo
Copy link
Member Author

Errors: 501
main@2023/07/28 12:07 JST

#4403
#4404
#4406

@HansRobo
Copy link
Member Author

Errors: 498
main@2023/07/31 10:09 JST

@HansRobo
Copy link
Member Author

spell-check-partial is enabled for system
#4460

@HansRobo
Copy link
Member Author

spell-check-partial will be enabled for launch and evaluator
#4462

@HansRobo
Copy link
Member Author

HansRobo commented Aug 3, 2023 •
edited
Loading

Errors: 492
main@2023/08/01 8:46 JST

@HansRobo
Copy link
Member Author

HansRobo commented Aug 3, 2023

Errors: 476
main@2023/08/02 9:13 JST

@HansRobo
Copy link
Member Author

Errors: 477
main@2023/08/07 11:45 JST

@HansRobo
Copy link
Member Author

Errors: 476
main@2023/08/09 17:41 JST

@HansRobo
Copy link
Member Author

Errors: 476
main@2023/08/10 10:16 JST

@HansRobo
Copy link
Member Author

Errors: 434
main@2023/08/18 14:56 JST

#4613

@HansRobo
Copy link
Member Author

Errors: 430
main@2023/08/21 14:04 JST

@kminoda
Copy link
Contributor

kminoda commented Aug 21, 2023 •
edited
Loading

Spell-check errors from each components (and some major packages) as of 2023/08/21

  • perception: 292
    • perception/bytetrack: 233 (already ignored in spell-check-partial)
    • perception/radar_object_tracker: 28
  • planning: 106
    • planning/sampling_based_planner: 39
  • sensing: 32

@kminoda
Copy link
Contributor

kminoda commented Aug 22, 2023

Errors: 372
main@2023/08/22 10:48 JST

@HansRobo
Copy link
Member Author

HansRobo commented Aug 23, 2023 •
edited
Loading

Errors: 328
main@2023/08/23 9:57 JST

we decided to ignore errors in svg files
tier4/autoware-spell-check-dict#616

@HansRobo HansRobo mentioned this issue Aug 23, 2023
Closed
4 tasks
@HansRobo
Copy link
Member Author

Errors: 305
main@2023/08/24 17:52 JST

#4716

@stale
Copy link

stale bot commented Oct 24, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HansRobo HansRobo

@kminoda kminoda

Labels
status:help-wanted Assistance or contributors needed. status:stale Inactive or outdated issues. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HansRobo @kminoda