Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cspell): add spell-check-all.yaml #4272

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

HansRobo
Copy link
Member

Description

Currently, spell-check-differential is one of the CI executed by pull requests as a trigger.
However, since there are too many cspell errors, the error is almost ignored.

Also, spell-check-differential cannot provide the full picture of the spell error in the repository.
Therefore, in order to accelerate the efforts to fix typo, I propose this workflow that can continue to track the entire cspell errors.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jul 13, 2023
@HansRobo HansRobo enabled auto-merge (squash) July 13, 2023 08:40
@HansRobo HansRobo requested a review from kminoda July 13, 2023 08:42
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansRobo HansRobo merged commit 2df0d6b into autowarefoundation:main Jul 14, 2023
@HansRobo
Copy link
Member Author

Thanks!

@HansRobo HansRobo deleted the chore/add-spell-check-all branch July 14, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants