Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTING CI 2: DO NOT MERGE #4329

Closed

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 19, 2023

PR with a typo in disabled components
Expected spell-check-partial behavior: pass
Expected spell-check-differential behavior: fail

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda changed the title add localization dummy package with a typo TESTING CI 2: DO NOT MERGE Jul 19, 2023
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jul 19, 2023
pre-commit-ci bot and others added 2 commits July 19, 2023 01:58
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6a4c495) 14.17% compared to head (c9a8b92) 14.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4329   +/-   ##
=======================================
  Coverage   14.17%   14.17%           
=======================================
  Files        1601     1601           
  Lines      110142   110142           
  Branches    31554    31554           
=======================================
  Hits        15610    15610           
  Misses      77575    77575           
  Partials    16957    16957           
Flag Coverage Δ *Carryforward flag
differential 22.91% <ø> (?)
total 14.17% <ø> (ø) Carriedforward from 6a4c495

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
localization/ekf_localizer/src/covariance.cpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HansRobo
Copy link
Member

Looks fine!
image

@kminoda kminoda closed this Jul 26, 2023
@kminoda kminoda deleted the dummy/add_typo_in_disabled_dirs branch August 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants