Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yabloc): fix typo #4281

Merged
merged 8 commits into from
Jul 19, 2023

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 14, 2023

Description

Fix a lot of typo

Related links

tier4/autoware-spell-check-dict#564

Tests performed

N/A

Notes for reviewers

N/A

Interface changes

N/A

Effects on system behavior

N/A

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda requested a review from KYabuuchi as a code owner July 14, 2023 04:38
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) labels Jul 14, 2023
kminoda and others added 7 commits July 14, 2023 13:54
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 9.30% and project coverage change: -0.01 ⚠️

Comparison is base (0443a08) 14.36% compared to head (f5fd033) 14.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4281      +/-   ##
==========================================
- Coverage   14.36%   14.36%   -0.01%     
==========================================
  Files        1567     1568       +1     
  Lines      107877   107904      +27     
  Branches    31249    31249              
==========================================
  Hits        15498    15498              
- Misses      75525    75552      +27     
  Partials    16854    16854              
Flag Coverage Δ *Carryforward flag
differential 4.68% <9.30%> (?)
total 14.36% <ø> (+<0.01%) ⬆️ Carriedforward from 0443a08

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...oc_common/src/ground_server/ground_server_core.cpp 0.00% <ø> (ø)
..._common/src/ll2_decomposer/ll2_decomposer_core.cpp 0.00% <0.00%> (ø)
...processing/graph_segment/similar_area_searcher.hpp 0.00% <ø> (ø)
...essing/src/graph_segment/similar_area_searcher.cpp 0.00% <0.00%> (ø)
...cessing/src/segment_filter/segment_filter_core.cpp 0.00% <0.00%> (ø)
...amera_corrector/camera_particle_corrector_core.cpp 0.00% <0.00%> (ø)
...lter/src/camera_corrector/filter_line_segments.cpp 0.00% <ø> (ø)
.../yabloc/yabloc_particle_filter/src/common/mean.cpp 0.00% <0.00%> (ø)
..._filter/src/gnss_corrector/gnss_corrector_core.cpp 0.00% <0.00%> (ø)
..._filter/src/ll2_cost_map/hierarchical_cost_map.cpp 0.00% <0.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the typeo!
I confirmed it works correctly with logging_simulator.

@kminoda kminoda merged commit 8723190 into autowarefoundation:main Jul 19, 2023
@kminoda kminoda deleted the fix/yabloc/a_lot_of_typo branch August 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants