Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yabloc_particle_filter): fix typo #4332

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 19, 2023

Description

Fix a typo

Related links

N/A

Tests performed

None

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda requested a review from KYabuuchi as a code owner July 19, 2023 02:31
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jul 19, 2023
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously OK

@kminoda kminoda enabled auto-merge (squash) July 19, 2023 02:36
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 13.33% and no project coverage change.

Comparison is base (665281e) 14.17% compared to head (7493134) 14.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4332   +/-   ##
=======================================
  Coverage   14.17%   14.18%           
=======================================
  Files        1601     1602    +1     
  Lines      110214   110137   -77     
  Branches    31602    31554   -48     
=======================================
  Hits        15623    15623           
+ Misses      77603    77526   -77     
  Partials    16988    16988           
Flag Coverage Δ *Carryforward flag
differential 10.36% <13.33%> (?)
total 14.18% <ø> (+0.01%) ⬆️ Carriedforward from 665281e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...oc_common/src/ground_server/ground_server_core.cpp 0.00% <ø> (ø)
..._common/src/ll2_decomposer/ll2_decomposer_core.cpp 0.00% <ø> (ø)
...processing/graph_segment/similar_area_searcher.hpp 0.00% <ø> (ø)
...essing/src/graph_segment/similar_area_searcher.cpp 0.00% <ø> (ø)
...cessing/src/segment_filter/segment_filter_core.cpp 0.00% <ø> (ø)
...amera_corrector/camera_particle_corrector_core.cpp 0.00% <0.00%> (ø)
...lter/src/camera_corrector/filter_line_segments.cpp 0.00% <ø> (ø)
.../yabloc/yabloc_particle_filter/src/common/mean.cpp 0.00% <0.00%> (ø)
...ticle_filter/src/correction/abstract_corrector.cpp 0.00% <ø> (ø)
..._filter/src/gnss_corrector/gnss_corrector_core.cpp 0.00% <0.00%> (ø)
... and 11 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kminoda kminoda merged commit 7c2f193 into autowarefoundation:main Jul 19, 2023
@kminoda kminoda deleted the fix/yabloc/fix_sychronization branch August 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants