Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): enable spell-check-partial for docs, simulator, tools, and vehicle dir #4327

Merged
merged 3 commits into from
Jul 25, 2023
Merged

feat(ci): enable spell-check-partial for docs, simulator, tools, and vehicle dir #4327

merged 3 commits into from
Jul 25, 2023

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 18, 2023 •
edited
Loading

Description

Enable spell-check-partial for following directories

  • docs
  • simulator
  • tools
  • vehicle

Related links

N/A

Tests performed

Check that those directories do NOT include any typos detected in spell-check-all

Notes for reviewers

Please check that those directories do NOT include any typos detected in spell-check-all

Interface changes

N/A

Effects on system behavior

N/A

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@HansRobo HansRobo mentioned this pull request Jul 19, 2023
Open
3 tasks
@HansRobo
Copy link
Member

HansRobo commented Jul 25, 2023 •
edited
Loading

There are already no cspell errors in new directories for spell-check-partial!
https://github.com/autowarefoundation/autoware.universe/actions/runs/5653529159/job/15314857934?pr=4327

@HansRobo HansRobo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 25, 2023
@kminoda
Copy link
Contributor Author

kminoda commented Jul 25, 2023

Forgot this!

@kminoda kminoda marked this pull request as ready for review July 25, 2023 07:13
@kminoda kminoda requested a review from HansRobo July 25, 2023 07:13
HansRobo
HansRobo approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, especially checking green spell-check-partial

@HansRobo HansRobo merged commit 4ae4705 into autowarefoundation:main Jul 25, 2023
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 26, 2023
Merged
@kminoda kminoda deleted the ci/enable_spell-check-partial_for_several_components branch August 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansRobo HansRobo HansRobo approved these changes

Assignees
No one assigned
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kminoda @HansRobo