-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify phpcs ruleset #579
Modify phpcs ruleset #579
Conversation
No need to test PHP nightly for now; 7 + 7.1 are good for now. Drop WordPress 4.5.
…rdering More term ordering fixes
Prepare v3.2.2 release
This reverts commit 0fbede4.
Script was stopping after no co-authors was find. Now script will display an error message and continue to the next post.
This reverts commit f759744.
This reverts commit 6e7da2b.
Script was stopping after no co-authors was find. Now script will display an error message and continue to the next post.
Resolves Automattic#417 * Removed duplicate left join for optimization
…bled() should do the trick now
This reverts commit 525f211.
This reverts commit 5ac7d9a.
Reduce amount of sleep
…into fix/489-skip-filtering-for-irrelevant-caps
* [Style] Identation changed to tab * [Feat] Added personal data exporter to guest authors * [Feat] Added a filter to allow third part plugins add guest author data * [Style] WPCS fixes * [Fix] Filter name changed * [Style] WPCS fixes * [Fix] Filter name changed
… of assertNotContains
…ests Re-enable disabled Test_Author_Queries tests
Add post type parameter to the Mine link, so it works for Pages
🐛Only filter author template for title
…repancy Fix possible discrepancy in author search with ignored authors
…ing-for-irrelevant-caps Skip irrelevant capabilities filtering in filter_user_has_cap() with whitelist
…ry-queries-on-multisite-test Removed Test_Author_Queried_Object setUp function
…linked-account column_posts() should use user_login when querying for linked_account
…count-guest-authors Fixing double posts counts for users with linked accounts
$ignored_authors in search should use user_nicename, not login.
The current phpcs ruleset is outdated (see Automattic#577). This commit updates it to the modern one.
The change here makes sense, in so much as the Ideally, along with #541 (which needs updating), the PHPCS config would be handled in |
Sounds good. @paulschreiber I'd be fine with closing this small PR if you integrated my changes into your larger one :) |
I updated #541 based on @GaryJones' suggestions. Let me know if anything else needs to be changed. |
I can't see the changes, the last commit I can view is from late June? https://github.com/Automattic/Co-Authors-Plus/pull/541/commits Maybe it's a problem with my account. @GaryJones can you see them? :( |
I'm not seeing the changes in the PR, either. Seeing updates in Automattic/liveblog#486. |
Closing this PR as the corresponding rule set had been updated accordingly in #751. |
The current phpcs ruleset is outdated (see #577). This commit updates it to the modern one.
The new build process has been tested successfully, you can see it passing here:
https://travis-ci.com/smistephen/Co-Authors-Plus/builds/80303610