Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify phpcs ruleset #579

Closed
wants to merge 306 commits into from
Closed

Modify phpcs ruleset #579

wants to merge 306 commits into from

Conversation

smistephen
Copy link
Contributor

The current phpcs ruleset is outdated (see #577). This commit updates it to the modern one.

The new build process has been tested successfully, you can see it passing here:
https://travis-ci.com/smistephen/Co-Authors-Plus/builds/80303610

mjangda and others added 30 commits March 28, 2017 14:00
No need to test PHP nightly for now; 7 + 7.1 are good for now. Drop
WordPress 4.5.
Script was stopping after no co-authors was find. Now script will
display an error message and continue to the next post.
Script was stopping after no co-authors was find. Now script will
display an error message and continue to the next post.
Resolves Automattic#417

* Removed duplicate left join for optimization
TheCrowned and others added 21 commits June 8, 2018 16:25
…into fix/489-skip-filtering-for-irrelevant-caps
* [Style] Identation changed to tab

* [Feat] Added personal data exporter to guest authors

* [Feat] Added a filter to allow third part plugins add guest author data

* [Style] WPCS fixes

* [Fix] Filter name changed

* [Style] WPCS fixes

* [Fix] Filter name changed
…ests

Re-enable disabled Test_Author_Queries tests
Add post type parameter to the Mine link, so it works for Pages
🐛Only filter author template for title
…repancy

Fix possible discrepancy in author search with ignored authors
…ing-for-irrelevant-caps

Skip irrelevant capabilities filtering in filter_user_has_cap() with whitelist
…ry-queries-on-multisite-test

Removed Test_Author_Queried_Object setUp function
…linked-account

column_posts() should use user_login when querying for linked_account
…count-guest-authors

Fixing double posts counts for users with linked accounts
$ignored_authors in search should use user_nicename, not login.
The current phpcs ruleset is outdated (see Automattic#577). This commit updates it to the modern one.
@GaryJones
Copy link
Contributor

The change here makes sense, in so much as the WordPress-VIP ruleset is deprecated, but what remains in Travis is still odd - PHPCompatibility is cloned, for instance, but the Travis script only runs PHPCS against the WordPressVIPMinimum standard.

Ideally, along with #541 (which needs updating), the PHPCS config would be handled in .phpcs.xml.dist, and then Travis can just call phpcs with no flags, so it is consistent to running it locally.

@GaryJones GaryJones mentioned this pull request Aug 6, 2018
@smistephen
Copy link
Contributor Author

Sounds good. @paulschreiber I'd be fine with closing this small PR if you integrated my changes into your larger one :)

@paulschreiber
Copy link
Contributor

I updated #541 based on @GaryJones' suggestions. Let me know if anything else needs to be changed.

@smistephen
Copy link
Contributor Author

I can't see the changes, the last commit I can view is from late June?

https://github.com/Automattic/Co-Authors-Plus/pull/541/commits

Maybe it's a problem with my account. @GaryJones can you see them? :(

@paulschreiber
Copy link
Contributor

I'm not seeing the changes in the PR, either. Seeing updates in Automattic/liveblog#486.

@nielslange
Copy link
Member

Closing this PR as the corresponding rule set had been updated accordingly in #751.

@nielslange nielslange closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.