PHPCS support #541

paulschreiber · 2018-06-08T13:24:45Z

add phpcs.xml
update composer.json
gitignore vendor folder
run PHPCBF to fix spacing problems

Script was stopping after no co-authors was find. Now script will display an error message and continue to the next post.

This reverts commit f759744.

This reverts commit 6e7da2b.

Script was stopping after no co-authors was find. Now script will display an error message and continue to the next post.

Resolves Automattic#417 * Removed duplicate left join for optimization

…bled() should do the trick now

This reverts commit 525f211.

This reverts commit 5ac7d9a.

Reduce amount of sleep

…r-posts Fixed WP CLI create-terms-for-posts if no co-authors found

Terminology updated throughout

…uthor Replace hardcoded 'author' with $this->$coauthor_taxonomy

Fixes warning: `Warning: sprintf(): Too few arguments in /path/wp-content/plugins/co-authors-plus/php/class-coauthors-guest-authors.php on line 487` Warning surfaces when deleting a guest author that is mapped to a WP user

Move parenthesis to fix esc_html and sprintf

…into fix/489-skip-filtering-for-irrelevant-caps

paulschreiber · 2018-06-08T18:03:41Z

Tests are passing. Failure was a travis error for WP4.8:

The "https://getcomposer.org/download/1.6.5/composer.phar.sig" file could not
be downloaded: failed to open stream: Connection timed out

* [Style] Identation changed to tab * [Feat] Added personal data exporter to guest authors * [Feat] Added a filter to allow third part plugins add guest author data * [Style] WPCS fixes * [Fix] Filter name changed * [Style] WPCS fixes * [Fix] Filter name changed

… of assertNotContains

…uthor_arg()

…__is_coauthor()

…ests Re-enable disabled Test_Author_Queries tests

Add post type parameter to the Mine link, so it works for Pages

🐛Only filter author template for title

…repancy Fix possible discrepancy in author search with ignored authors

…ing-for-irrelevant-caps Skip irrelevant capabilities filtering in filter_user_has_cap() with whitelist

…ccount

…ry-queries-on-multisite-test Removed Test_Author_Queried_Object setUp function

…linked-account column_posts() should use user_login when querying for linked_account

…count-guest-authors Fixing double posts counts for users with linked accounts

$ignored_authors in search should use user_nicename, not login.

GaryJones · 2018-08-06T10:48:07Z

composer.json

@@ -22,6 +22,8 @@
 			"forum": "http://wordpress.org/support/plugin/co-authors-plus"
 	},
 	"require": {
-		"composer/installers": "~1.0"
+		"composer/installers": "~1.0",
+		"wp-coding-standards/wpcs": "^0.14.0",


This should now be ^1.0.

GaryJones · 2018-08-06T10:49:10Z

phpcs.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0"?>


This should be named .phpcs.xml.dist or phpcs.xml.dist, and then add .phpcs.xml and phpcs.xml to the .gitignore, so that folks can override it locally if they wish.

GaryJones · 2018-08-06T10:50:46Z

phpcs.xml

+<?xml version="1.0"?>
+<ruleset name="WordPress Coding Standards for Co-Authors Plus">
+
+	<rule ref="WordPress-VIP" />


Don't include WordPress-VIP here. See #579

GaryJones · 2018-08-06T11:03:08Z

phpcs.xml

+	<rule ref="WordPress-Docs" />
+	<rule ref="WordPress-Extra" />
+
+	<arg value="s"/>


Consider adding flags to show progress, use shorter basepath, adding colors etc. The exact args available depends on what PHPCS version is installed, and that depends on what minimum PHP version should be supported.

GaryJones · 2018-08-06T11:04:20Z

phpcs.xml

+
+	<exclude-pattern>*/node_modules/*</exclude-pattern>
+	<exclude-pattern>*/vendor/*</exclude-pattern>
+</ruleset>


By enabling some custom properties (see https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Customizable-sniff-properties#properties-strongly-recommended-to-be-set) then extra checks, such as textdomains and deprecations will also be run.

GaryJones · 2023-07-27T22:06:48Z

Some of the config changes have been handled more recently, and some of the changes are now redundant. There is a lot of PHPCS to tidy up, but it's going to be needed to be done in smaller chunks.

Rebecca Hum and others added 30 commits May 30, 2017 12:09

Fixed WP CLI create-terms-for-posts if no co-authors found

f759744

Script was stopping after no co-authors was find. Now script will display an error message and continue to the next post.

Revert "Fixed WP CLI create-terms-for-posts if no co-authors found"

76c59ef

This reverts commit f759744.

Revert "Removed duplicate left join for optimization"

9f8a1d5

This reverts commit 6e7da2b.

Fixed WP CLI create-terms-for-posts if no co-authors found

68bcb6e

Script was stopping after no co-authors was find. Now script will display an error message and continue to the next post.

Removed double left join on posts_join_filter (Automattic#419)

a5222a9

Resolves Automattic#417 * Removed duplicate left join for optimization

Merge remote-tracking branch 'upstream/master'

8ab4751

CoAuthors display now for Pages and JS is being enqueued on Pages

ea4ef62

JS error goes away from js_vars()

bcc875b

changed is_post_type_enabled() to clean up code

f226e9c

removed extra whitespace

29e1e90

removed all traces of $post_type in functions, since is_post_type_ena…

6b3ea35

…bled() should do the trick now

Revert "Update version constant"

5ac7d9a

This reverts commit 525f211.

Edited words to match glossary

8f498c4

Removed continue because the script would stop running.

8ba4611

Added better consistencies with glossary

4c23011

Merge branch 'master' into reduce-sleep

8c23eeb

Revert "Revert "Update version constant""

586dcdc

This reverts commit 5ac7d9a.

doesn't return false after quick edit saves

1a272fa

replaced hardcoded 'author' with $this->coauthor_taxonomy

84d8394

Tested tag to 4.8

5206a53

Merge pull request Automattic#400 from Automattic/reduce-sleep

20efecf

Reduce amount of sleep

Merge pull request Automattic#420 from rebeccahum/cli-create-terms-fo…

7bdae3c

…r-posts Fixed WP CLI create-terms-for-posts if no co-authors found

Merge pull request Automattic#423 from rebeccahum/terminology

1f61855

Terminology updated throughout

Merge pull request Automattic#426 from rebeccahum/replace_hardcoded_a…

39276d1

…uthor Replace hardcoded 'author' with $this->$coauthor_taxonomy

Move parenthesis to fix esc_html and sprintf

830987b

Fixes warning: `Warning: sprintf(): Too few arguments in /path/wp-content/plugins/co-authors-plus/php/class-coauthors-guest-authors.php on line 487` Warning surfaces when deleting a guest author that is mapped to a WP user

Added progress so users have an idea of how long it will take

06c123d

Merge pull request Automattic#430 from Automattic/trepmal-patch-1

832ac30

Move parenthesis to fix esc_html and sprintf

Added a better style of progress bar!

b91e7d4

Deleting guest authors is less confusing

d404fec

Fixed merge conflicts

19d94b9

paulschreiber and others added 3 commits June 8, 2018 09:29

remove spaces used for alignment

18f4691

Skipping irrelevant cap checks through list of allowed caps.

0c623dc

Merge branch 'master' of https://github.com/Automattic/Co-Authors-Plus …

1ad6e50

…into fix/489-skip-filtering-for-irrelevant-caps

mariovalney and others added 20 commits June 13, 2018 11:21

Updated tests to search_authors() to use assertArrayNotHasKey instead…

7938853

… of assertNotContains

Re-enabled Test_Author_Queries->test__author_arg__user_is_coauthor__a…

2be4599

…uthor_arg()

Re-enabled Test_Author_Queries->tests__author_name_arg_plus_tax_query…

d559799

…__is_coauthor()

Improved inline doc

08902e5

Merge pull request Automattic#546 from TheCrowned/fix/538-re-enable-t…

d63ab9b

…ests Re-enable disabled Test_Author_Queries tests

Add post type parameter to the Mine link, so it works for Pages

96a0efa

Merge pull request Automattic#547 from pdemarte/post-type-pages-fix

b0c2871

Add post type parameter to the Mine link, so it works for Pages

Merge branch 'master' into patch-1

ab422f7

Merge pull request Automattic#535 from jacobarriola/patch-1

7f3651a

🐛Only filter author template for title

Merge branch 'master' into fix/phpcs

2ed467e

Merge pull request Automattic#532 from TheCrowned/fix/273-search-disc…

773a368

…repancy Fix possible discrepancy in author search with ignored authors

Merge pull request Automattic#543 from TheCrowned/fix/489-skip-filter…

604b3f0

…ing-for-irrelevant-caps Skip irrelevant capabilities filtering in filter_user_has_cap() with whitelist

Changed get_user_by('slug' to get_user_by('login' when using linked_a…

7a702bd

…ccount

Merge pull request Automattic#540 from TheCrowned/fix/526-non-tempora…

5962064

…ry-queries-on-multisite-test Removed Test_Author_Queried_Object setUp function

Merge pull request Automattic#558 from TheCrowned/fix/554-user-login-…

1bb6378

…linked-account column_posts() should use user_login when querying for linked_account

Only using new cap- prefixed term when counting user posts.

ecf8699

Merge pull request Automattic#567 from TheCrowned/fix/561-wrong-post-…

68de11d

…count-guest-authors Fixing double posts counts for users with linked accounts

$ignored_authors in search should use user_nicename, not login.

f3e4333

Merge pull request Automattic#569 from TheCrowned/fix/568-failing-test

1dd63e7

$ignored_authors in search should use user_nicename, not login.

GaryJones mentioned this pull request Aug 6, 2018

Modify phpcs ruleset #579

Closed

GaryJones requested changes Aug 6, 2018

View reviewed changes

Merge branch 'master' into fix/phpcs

e2164fc

rebeccahum force-pushed the master branch from 4e1b2d4 to f37f410 Compare March 26, 2019 05:42

GaryJones closed this Jul 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHPCS support #541

PHPCS support #541

paulschreiber commented Jun 8, 2018

paulschreiber commented Jun 8, 2018

GaryJones Aug 6, 2018

GaryJones Aug 6, 2018

GaryJones Aug 6, 2018

GaryJones Aug 6, 2018

GaryJones Aug 6, 2018

GaryJones commented Jul 27, 2023

PHPCS support #541

PHPCS support #541

Conversation

paulschreiber commented Jun 8, 2018

paulschreiber commented Jun 8, 2018

GaryJones Aug 6, 2018

Choose a reason for hiding this comment

GaryJones Aug 6, 2018

Choose a reason for hiding this comment

GaryJones Aug 6, 2018

Choose a reason for hiding this comment

GaryJones Aug 6, 2018

Choose a reason for hiding this comment

GaryJones Aug 6, 2018

Choose a reason for hiding this comment

GaryJones commented Jul 27, 2023