Re-enable disabled Test_Author_Queries tests #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sboisvert
approved these changes
Jun 18, 2018
rebeccahum
pushed a commit
that referenced
this pull request
Mar 26, 2019
Re-enable disabled Test_Author_Queries tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #538.
Test_Author_Queries->test__author_arg__user_is_coauthor__author_arg()andTest_Author_Queries->tests__author_name_arg_plus_tax_query__is_coauthor()had been deactivated because failed. I was looking at the reason why that should be the case (even before trying to execute them), and I couldn't find any - it all looked okay! Then I simply re-activated them without changing anything, and it looks like they work fine!The issues in the code that prevented them from working were fixed in #388 (in particular, fd08f52) for the first test, and #376 (in particular, 786777a) for the second test, I believe.
I tried to run PHPUnit after re-enabling both, and it just went through smoothly!