Skip to content

Commit

Permalink
Merge pull request #546 from TheCrowned/fix/538-re-enable-tests
Browse files Browse the repository at this point in the history
Re-enable disabled Test_Author_Queries tests
  • Loading branch information
sboisvert authored Jun 18, 2018
2 parents 2026d4c + d559799 commit d63ab9b
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions tests/test-author-queries.php
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ public function test__author_name_arg__user_is_coauthor() {
}

public function test__author_arg__user_is_coauthor__author_arg() {
return; // TODO: re-enable; fails currently because WordPress generates query as `post_author IN (id)` which doesn't match our regex in the posts_where filter.

$author1_id = $this->factory->user->create( array( 'role' => 'author', 'user_login' => 'batman' ) );
$author1 = get_userdata( $author1_id );
$author2_id = $this->factory->user->create( array( 'role' => 'author', 'user_login' => 'superman' ) );
Expand Down Expand Up @@ -103,8 +101,6 @@ public function test__author_name_arg_plus_tax_query__user_is_post_author() {
}

public function tests__author_name_arg_plus_tax_query__is_coauthor() {
return; // TODO: re-enable; fails currently because our posts_join_filter doesn't add an exclusive JOIN on relationships + taxonomy to match the query mods we make. We'd need aliased JOINs on relationships + taxonomy on top of the JOIN that the tax query already adds.

$author1_id = $this->factory->user->create( array( 'role' => 'author', 'user_login' => 'batman' ) );
$author1 = get_userdata( $author1_id );
$author2_id = $this->factory->user->create( array( 'role' => 'author', 'user_login' => 'superman' ) );
Expand Down

0 comments on commit d63ab9b

Please sign in to comment.