Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests skipped because broken, need to re-enable them #538

Closed
TheCrowned opened this issue Jun 8, 2018 · 0 comments · Fixed by #546
Closed

Tests skipped because broken, need to re-enable them #538

TheCrowned opened this issue Jun 8, 2018 · 0 comments · Fixed by #546

Comments

@TheCrowned
Copy link
Contributor

The following two tests are failing and are currently not running due to an immediate return. The issue is well detailed inline, and I am copying it here for reference. We should update them and re-enable them.

  • Test_Author_Queries::test__author_arg__user_is_coauthor__author_arg(): fails currently because WordPress generates query as post_author IN (id) which doesn't match our regex in the posts_where filter.
  • Test_Author_Queries::tests__author_name_arg_plus_tax_query__is_coauthor(): fails currently because our posts_join_filter doesn't add an exclusive JOIN on relationships + taxonomy to match the query mods we make. We'd need aliased JOINs on relationships + taxonomy on top of the JOIN that the tax query already adds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant