Removed Test_Author_Queried_Object setUp function

[TheCrowned]

This fixes #526 - test__author_queried_object_fix() fails when run twice.

After tests are run, the database should be properly cleaned by the WP testcase itself, so I dug into the core tests handling to see why that was not happening. Apparently, all queries were being run as TEMPORARY, except the ones from this test. Thus, this statement (which is where the test hanged for me):

$blog2 = $this->factory->blog->create( array( 'user_id' => $author1 ) );

failed, because the blog (and related db tables) were already present.

And indeed, it failed because of the filters in test-author-queried-object.php setUp() function, which prevented the default behavior of declaring the new site tables as TEMPORARY. Commenting those two filters out, tests succeed AND can be run an arbitrary number of times (without throwing any errors).

function setUp() {
	parent::setUp();

	//remove_filter( 'query', array( $this, '_create_temporary_tables' ) );
	//remove_filter( 'query', array( $this, '_drop_temporary_tables' ) );
}

As a side note, WP_UnitTestCase->tearDown(), which executes $wpdb->query( 'ROLLBACK' ); and thus deletes all temporary tables, is called at the end of each plugin test, so it shouldn't create any issues, and those filters are not needed.

I have thus deleted the whole function, since it was not doing anything besides setting up the filters. All tests still pass okay!

[sboisvert]

lgtm, I really like the thorough explanations!