$ignored_authors in search should use user_nicename, not login. #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
rebeccahum
added a commit
that referenced
this pull request
Mar 26, 2019
$ignored_authors in search should use user_nicename, not login.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #568.
As per #532, the
$ignored_authorsarg tosearch_authors()should take an array ofuser_nicenames, notuser_logins. The second test intest_search_authors_when_ignored_authors_provided()would fail because of this, whiletest_search_authors_when_search_keyword_and_ignored_authors_provided()could fail. I addressed them both. They all succeed now.