Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI build process uses deprecated phpcs ruleset #577

Closed
smistephen opened this issue Jul 27, 2018 · 1 comment
Closed

CI build process uses deprecated phpcs ruleset #577

smistephen opened this issue Jul 27, 2018 · 1 comment
Labels
Status: has patch

Comments

@smistephen
Copy link
Contributor

Travis currently checks code against the WordPress-VIP ruleset:
https://github.com/Automattic/Co-Authors-Plus/blob/master/.travis.yml#L78

This ruleset is deprecated and set to be removed:
WordPress/WordPress-Coding-Standards#1309

Solution: Move to the WordPressVIPMinimum ruleset:
https://github.com/Automattic/VIP-Coding-Standards
smistephen added a commit to smistephen/Co-Authors-Plus that referenced this issue Jul 29, 2018
@smistephen
Modify phpcs ruleset
bdcb84c 
The current phpcs ruleset is outdated (see Automattic#577). This commit updates it to the modern one.
@smistephen smistephen mentioned this issue Jul 29, 2018
Closed
@nielslange
Copy link
Member

Closing this issue as the corresponding rule set had been updated accordingly in #751.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: has patch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nielslange @smistephen