Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky TestClientIdRequestObjectWithContext #244

Closed
oleg-jukovec opened this issue Dec 5, 2022 · 0 comments · Fixed by #253
Closed

Flaky TestClientIdRequestObjectWithContext #244

oleg-jukovec opened this issue Dec 5, 2022 · 0 comments · Fixed by #253
Assignees
@oleg-jukovec
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@oleg-jukovec
Copy link
Collaborator 

2022-12-05T10:18:16.0993007Z === RUN   TestClientIdRequestObjectWithContext
2022-12-05T10:18:16.1012546Z --- FAIL: TestClientIdRequestObjectWithContext (0.00s)
2022-12-05T10:18:16.1012900Z     tarantool_test.go:2989: 
2022-12-05T10:18:16.1013296Z         	Error Trace:	tarantool_test.go:2989
2022-12-05T10:18:16.1016919Z         	Error:      	Expected nil, but got: &tarantool.Response{RequestId:0x3, Code:0x30, Error:"Unknown request type 73", Data:[]interface {}(nil), MetaData:[]tarantool.ColumnMetaData(nil), SQLInfo:tarantool.SQLInfo{AffectedCount:0x0, InfoAutoincrementIds:[]uint64(nil)}, buf:tarantool.smallBuf{b:[]uint8{0x83, 0x0, 0xce, 0x0, 0x0, 0x80, 0x30, 0x1, 0xcf, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x3, 0x5, 0xce, 0x0, 0x0, 0x0, 0x69, 0x82, 0x31, 0xb7, 0x55, 0x6e, 0x6b, 0x6e, 0x6f, 0x77, 0x6e, 0x20, 0x72, 0x65, 0x71, 0x75, 0x65, 0x73, 0x74, 0x20, 0x74, 0x79, 0x70, 0x65, 0x20, 0x37, 0x33, 0x52, 0x81, 0x0, 0x91, 0x86, 0x0, 0xab, 0x43, 0x6c, 0x69, 0x65, 0x6e, 0x74, 0x45, 0x72, 0x72, 0x6f, 0x72, 0x2, 0xcd, 0x5, 0x22, 0x1, 0xd9, 0x2c, 0x2f, 0x5f, 0x5f, 0x77, 0x2f, 0x73, 0x64, 0x6b, 0x2f, 0x73, 0x64, 0x6b, 0x2f, 0x74, 0x61, 0x72, 0x61, 0x6e, 0x74, 0x6f, 0x6f, 0x6c, 0x2d, 0x32, 0x2e, 0x38, 0x2f, 0x73, 0x72, 0x63, 0x2f, 0x62, 0x6f, 0x78, 0x2f, 0x69, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x2e, 0x63, 0x63, 0x3, 0xb7, 0x55, 0x6e, 0x6b, 0x6e, 0x6f, 0x77, 0x6e, 0x20, 0x72, 0x65, 0x71, 0x75, 0x65, 0x73, 0x74, 0x20, 0x74, 0x79, 0x70, 0x65, 0x20, 0x37, 0x33, 0x4, 0x0, 0x5, 0x30}, p:23}}
2022-12-05T10:18:16.1018509Z         	Test:       	TestClientIdRequestObjectWithContext
2022-12-05T10:18:16.1018887Z         	Messages:   	Response is empty

https://github.com/tarantool/go-tarantool/actions/runs/3618947238/jobs/6099414757
@oleg-jukovec oleg-jukovec added bug Something isn't working good first issue Good for newcomers 1sp labels Dec 5, 2022
@oleg-jukovec oleg-jukovec self-assigned this Dec 27, 2022
oleg-jukovec added a commit that referenced this issue Dec 27, 2022
@oleg-jukovec
test: add Ctx() test for requests
3d37409 
Part of #244
oleg-jukovec added a commit that referenced this issue Dec 27, 2022
@oleg-jukovec
code health: simplify context checks
091b938 
We don't need to over-optimize the work with requests with contexts
that already done. It doesn't look like a work method. It is better
to simplify the code.

Part of #244
oleg-jukovec added a commit that referenced this issue Dec 27, 2022
@oleg-jukovec
bugfix: flaky TestClientRequestObjectsWithContext
58c4f0b 
The patch makes the test more deterministic. It helps to avoid
canceling a request with an already received response.

Closes #244
@oleg-jukovec oleg-jukovec mentioned this issue Dec 27, 2022
Merged
2 tasks
oleg-jukovec added a commit that referenced this issue Dec 27, 2022
@oleg-jukovec
code health: simplify context checks
6c2f319 
We don't need to over-optimize the work with requests with contexts
that already done. It doesn't look like a use case. It is better
to simplify the code.

Part of #244
oleg-jukovec added a commit that referenced this issue Dec 27, 2022
@oleg-jukovec
bugfix: flaky TestClientRequestObjectsWithContext
f1f00bb 
The patch makes the test more deterministic. It helps to avoid
canceling a request with an already received response.

Closes #244
oleg-jukovec added a commit that referenced this issue Dec 28, 2022
@oleg-jukovec
test: add Ctx() test for requests
98eb661 
Part of #244
oleg-jukovec added a commit that referenced this issue Dec 28, 2022
@oleg-jukovec
code health: simplify context checks
e8abc17 
We don't need to over-optimize the work with requests with contexts
that already done. It doesn't look like a use case. It is better
to simplify the code.

Part of #244
oleg-jukovec added a commit that referenced this issue Dec 28, 2022
@oleg-jukovec
bugfix: flaky TestClientRequestObjectsWithContext
41532b6 
The patch makes the test more deterministic. It helps to avoid
canceling a request with an already received response.

Closes #244
oleg-jukovec added a commit that referenced this issue Dec 28, 2022
@oleg-jukovec
Release 1.10.0
5aca571 
Overview

    The release improves compatibility with new Tarantool versions.

Breaking changes

    There are no breaking changes in the release.

New features

    Support iproto feature discovery (#120).

    Support errors extended information (#209).

    Support error type in MessagePack (#209).

    Support event subscriptin (#119).

    Support session settings (#215).

    Support pap-sha256 authorization method (Tarantool EE
    feature) (#243).

    Support graceful shutdown (#214).

Bugfixes

    Decimal package uses a test variable DecimalPrecision instead
    of a package-level variable decimalPrecision (#233).

    Flaky test TestClientRequestObjectsWithContext (#244).

    Flaky test multi/TestDisconnectAll (#234).
@oleg-jukovec oleg-jukovec mentioned this issue Dec 28, 2022
Merged
oleg-jukovec added a commit that referenced this issue Dec 29, 2022
@oleg-jukovec
Release 1.10.0
a8da132 
Overview

    The release improves compatibility with new Tarantool versions.

Breaking changes

    There are no breaking changes in the release.

New features

    Support iproto feature discovery (#120).

    Support errors extended information (#209).

    Support error type in MessagePack (#209).

    Support event subscription (#119).

    Support session settings (#215).

    Support pap-sha256 authorization method (Tarantool EE
    feature) (#243).

    Support graceful shutdown (#214).

Bugfixes

    Decimal package uses a test variable DecimalPrecision instead
    of a package-level variable decimalPrecision (#233).

    Flaky test TestClientRequestObjectsWithContext (#244).

    Flaky test multi/TestDisconnectAll (#234).
oleg-jukovec added a commit that referenced this issue Dec 30, 2022
@oleg-jukovec
Release 1.10.0
0f59c42 
Overview

    The release improves compatibility with new Tarantool versions.

Breaking changes

    There are no breaking changes in the release.

New features

    Support iproto feature discovery (#120).

    Support errors extended information (#209).

    Support error type in MessagePack (#209).

    Support event subscription (#119).

    Support session settings (#215).

    Support pap-sha256 authorization method (Tarantool EE
    feature) (#243).

    Support graceful shutdown (#214).

Bugfixes

    Decimal package uses a test variable DecimalPrecision instead
    of a package-level variable decimalPrecision (#233).

    Flaky test TestClientRequestObjectsWithContext (#244).

    Flaky test multi/TestDisconnectAll (#234).
pull bot pushed a commit to kokizzu/go-tarantool that referenced this issue Jan 1, 2023
@oleg-jukovec
Release 1.10.0
0ffd926 
Overview

    The release improves compatibility with new Tarantool versions.

Breaking changes

    There are no breaking changes in the release.

New features

    Support iproto feature discovery (tarantool#120).

    Support errors extended information (tarantool#209).

    Support error type in MessagePack (tarantool#209).

    Support event subscription (tarantool#119).

    Support session settings (tarantool#215).

    Support pap-sha256 authorization method (Tarantool EE
    feature) (tarantool#243).

    Support graceful shutdown (tarantool#214).

Bugfixes

    Decimal package uses a test variable DecimalPrecision instead
    of a package-level variable decimalPrecision (tarantool#233).

    Flaky test TestClientRequestObjectsWithContext (tarantool#244).

    Flaky test multi/TestDisconnectAll (tarantool#234).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleg-jukovec oleg-jukovec

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: flaky TestClientRequestObjectsWithContext tarantool/go-tarantool
1 participant
@oleg-jukovec