Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: flaky TestClientRequestObjectsWithContext #253

Merged
merged 3 commits into from
Dec 28, 2022

Conversation

oleg-jukovec
Copy link
Collaborator

The patch makes the test more deterministic. It helps to avoid
canceling a request with an already received response.

I didn't forget about (remove if it is not applicable):

Related issues:

Closes #244

connection.go Show resolved Hide resolved
connection.go Show resolved Hide resolved
We don't need to over-optimize the work with requests with contexts
that already done. It doesn't look like a use case. It is better
to simplify the code.

Part of #244
The patch makes the test more deterministic. It helps to avoid
canceling a request with an already received response.

Closes #244
@oleg-jukovec oleg-jukovec force-pushed the oleg-jukovec/gh-244-fix-flaky-withcontext branch from 58c4f0b to f1f00bb Compare December 27, 2022 15:15
@oleg-jukovec oleg-jukovec merged commit 41532b6 into master Dec 28, 2022
@oleg-jukovec oleg-jukovec deleted the oleg-jukovec/gh-244-fix-flaky-withcontext branch December 28, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky TestClientIdRequestObjectWithContext
3 participants